Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import support for Auxiliary Plugins in PDE/BND setups #1054

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

laeubi
Copy link
Contributor

@laeubi laeubi commented Jan 15, 2024

BND allows arbitrary plugins to be provided, to account for this there is a special mechanism for an OSGi classpath that is a package is exported with <package>;bnd-plugins=true and a weaving hook is used to add additional dynamic imports.

This is specifically required for the biz.aQute.repository bundle that provides e.g. maven repository support.

CQ created here:

Copy link

github-actions bot commented Jan 15, 2024

Test Results

   277 files  +    6     277 suites  +6   54m 27s ⏱️ + 10m 19s
 3 496 tests  -     1   3 460 ✅ ±    0   36 💤 ± 0  0 ❌  - 1 
10 619 runs  +2 721  10 517 ✅ +2 698  102 💤 +24  0 ❌  - 1 

Results for commit 786b5f2. ± Comparison against base commit 97c94fe.

This pull request removes 1 test.
AllPDETests org.eclipse.pde.ui.tests.launcher.AllLauncherTests org.eclipse.pde.ui.tests.launcher.FeatureBasedLaunchTest ‑ Unknown test

♻️ This comment has been updated with latest results.

@laeubi laeubi marked this pull request as ready for review January 16, 2024 10:26
@laeubi
Copy link
Contributor Author

laeubi commented Jan 16, 2024

CQ accepted!

BND allows arbitrary plugins to be provided, to account for this there
is a special mechanism for an OSGi classpath that is a package is
exported with '<package>;bnd-plugins=true' and a weaving hook is used to
add additional dynamic imports.

This is specifically required for the biz.aQute.repository bundle that
provides e.g. maven repository support.
@laeubi laeubi merged commit 44feae5 into eclipse-pde:master Jan 16, 2024
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant