[426] Improve GMFHelper.getAbsoluteBounds method #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lredor
force-pushed
the
lre/enh/426-GMFHelper
branch
4 times, most recently
from
44700cb
to
515600d
Compare
lredor
force-pushed
the
lre/enh/426-GMFHelper
branch
2 times, most recently
from
0878225
to
a383ea5
Compare
lredor
changed the title
|
Remaining TODO exist and all cases are not correctly handle. But this is a first step. All tests added in org.eclipse.sirius.tests.swtbot.layout.GMFHelperTest are OK now. |
lredor
force-pushed
the
lre/enh/426-GMFHelper
branch
2 times, most recently
from
2f15dd5
to
8a65d0e
Compare
This was referenced Sep 12, 2024
lredor
force-pushed
the
lre/enh/426-GMFHelper
branch
2 times, most recently
from
441bc92
to
add67ae
Compare
Because of typo, the border nodes are considered in org.eclipse.sirius.diagram.ui.internal.refresh.GMFHelper.getBottomRight(Node) when they should be ignored. Bug: #426
* Add method getBottomRightInsets to use it in auto-size computation * Consider shadow border * Consider border nodes when computing children bottom-right corner. Bug: #426
The code will be more logic with this refactoring and facilitate the following changes. Bug: #426
This compartment is an intermediate GMF Node and should not have the same behavior when computing auto-size: - Minimal size defined by ResizableCompartmentFigure.MIN_CLIENT_DP - No shadow border Bug: #426
Before this commit, this kind of container was not correctly handled. Bug: #426
Before this commit, this kind of container was not correctly handled. Bug: #426
Before this commit, this kind of container was not correctly handled. Bug: #426
This test was based on some wrong bounds. The edge has been slightly moved to retrieve the previous edge bendpoints number after collapse. Bug: #426
The bounds for a node can be computed several times for a parent or a child bounds calculation. This commit adds a cache to avoid computing it again. Bug: #426
Analysis: It seems that before, the code with comment "manage location of bordered node with closest side", in GMFHelper.getAbsoluteLocation, is called only in specific circumstances. Since recent changes, it was called systematically, but that shouldn't be the case. This commit also reduces the number of getAbsoluBounds methods to ease the impact analysis. Bug: #426
All classes, using methods from GMFHelper with Option as return type, have also been modified.
lredor
force-pushed
the
lre/enh/426-GMFHelper
branch
from
add67ae
to
3e2cd62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several points are handled in this commit. It should maybe split in several commit to facilitate reviewing...
Because of typo, the border nodes are considered in org.eclipse.sirius.diagram.ui.internal.refresh.GMFHelper.getBottomRight(Node) when they should be ignored.
Bug: #426