Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take into account all elements of the selection to compute the edit project URL #4376

Open
sbegaudeau opened this issue Jan 6, 2025 · 0 comments · May be fixed by #4461
Open

Take into account all elements of the selection to compute the edit project URL #4376

sbegaudeau opened this issue Jan 6, 2025 · 0 comments · May be fixed by #4461
Labels
difficulty: medium package: sirius web type: enhancement
Milestone
2025.2.0

Comments

@sbegaudeau
Copy link
Member

It should be possible to have and thus share an URL with not only the currently selected representation but also the currently selected semantic elements. It should be noted that we should probably stop distinguishing semantic elements from the representations in managing the selection in EditProjectView.

The shape should thus take into accounts use cases with a multi-selection (with multiple semantic elements AND/OR multiple representations).
@sbegaudeau sbegaudeau added this to the 2025.2.0 milestone Jan 6, 2025
flatombe added a commit to flatombe/sirius-web-dev that referenced this issue Jan 15, 2025
@flatombe
[doc] Add shape for supporting selections in URLs (WIP)
fbe13bb 
Bug: eclipse-sirius#4376
Signed-off-by: Florent Latombe <[email protected]>
flatombe added a commit to flatombe/sirius-web-dev that referenced this issue Jan 17, 2025
@flatombe
[doc] Add shape for supporting selections in URLs
b55436d 
Bug: eclipse-sirius#4376
Signed-off-by: Florent Latombe <[email protected]>
@flatombe flatombe mentioned this issue Jan 17, 2025
Merged
39 tasks
sbegaudeau pushed a commit to flatombe/sirius-web-dev that referenced this issue Jan 20, 2025
@flatombe @sbegaudeau
[doc] Add shape for supporting selections in URLs
bd69167 
Bug: eclipse-sirius#4376
Signed-off-by: Florent Latombe <[email protected]>
sbegaudeau pushed a commit to flatombe/sirius-web-dev that referenced this issue Jan 20, 2025
@flatombe @sbegaudeau
[doc] Add shape for supporting selections in URLs
546e4d6 
Bug: eclipse-sirius#4376
Signed-off-by: Florent Latombe <[email protected]>
sbegaudeau pushed a commit to flatombe/sirius-web-dev that referenced this issue Jan 20, 2025
@flatombe @sbegaudeau
[doc] Add shape for supporting selections in URLs
7cb13ee 
Bug: eclipse-sirius#4376
Signed-off-by: Florent Latombe <[email protected]>
sbegaudeau pushed a commit that referenced this issue Jan 20, 2025
@flatombe @sbegaudeau
[doc] Add shape for supporting selections in URLs
2146030 
Bug: #4376
Signed-off-by: Florent Latombe <[email protected]>
flatombe added a commit to flatombe/sirius-web-dev that referenced this issue Jan 23, 2025
@flatombe
[4376] Add current selection as a URL search parameter (WIP)
b4507e3 
* When the workbench selection changes, the URL search parameters are
now automatically updated to encode the contents of the selection.
* Reversely, when resolving a URL with such search parameters, the
workbench selection is set to those specified elements.

Bug: eclipse-sirius#4376
Signed-off-by: Florent Latombe <[email protected]>
flatombe added a commit to flatombe/sirius-web-dev that referenced this issue Jan 23, 2025
@flatombe
[4376] Add current selection as a URL search parameter (WIP)
4a3ad53 
* When the workbench selection changes, the URL search parameters are
now automatically updated to encode the contents of the selection.
* Reversely, when resolving a URL with such search parameters, the
workbench selection is set to those specified elements.

Known limitations/bugs:
* Start from a (diagram) representation with a selection of elements in
the diagram. Select either the diagram representation in the 'Explorer'
view, or the diagram background. The selection gets set to the diagram
representation, but quickly evolves into an empty selection. This does
not occur when starting from a selection of elements that are not shown
in the diagram, or from an empty selection.
* When loading a URL with an opened representation and a selection of
elements, the selection is properly applied in the 'Explorer' view, but
not in the diagram.

Bug: eclipse-sirius#4376
Signed-off-by: Florent Latombe <[email protected]>
flatombe added a commit to flatombe/sirius-web-dev that referenced this issue Jan 23, 2025
@flatombe
[4376] Add Workbench prop to apply an effect based on a Selection
6a9d271 
Bug: eclipse-sirius#4376
Signed-off-by: Florent Latombe <[email protected]>
flatombe added a commit to flatombe/sirius-web-dev that referenced this issue Jan 23, 2025
@flatombe
[4376] Make navigation in EditProjectView preserve URL search params
c4886fc 
Bug: eclipse-sirius#4376
Signed-off-by: Florent Latombe <[email protected]>
flatombe added a commit to flatombe/sirius-web-dev that referenced this issue Jan 23, 2025
@flatombe
[4376] Add current selection as a URL search parameter (WIP2)
bf6f604 
* When the workbench selection changes, the URL search parameters are
now automatically updated to encode the contents of the selection.
* Reversely, when resolving a URL with such search parameters, the
workbench selection is set to those specified elements.

Known limitations/bugs:
* Start from a (diagram) representation with a selection of elements in
the diagram. Select either the diagram representation in the 'Explorer'
view, or the diagram background. The selection gets set to the diagram
representation, but quickly evolves into an empty selection. This does
not occur when starting from a selection of elements that are not shown
in the diagram, or from an empty selection.
* When loading a URL with an opened representation and a selection of
elements, the selection is properly applied in the 'Explorer' view, but
not in the diagram.

Bug: eclipse-sirius#4376
Signed-off-by: Florent Latombe <[email protected]>
flatombe added a commit to flatombe/sirius-web-dev that referenced this issue Jan 23, 2025
@flatombe
[4376] Add current selection as a URL search parameter (WIP)
32cd984 
* When the workbench selection changes, the URL search parameters are
now automatically updated to encode the contents of the selection (id
and kind).
* Reversely, when resolving a URL with such search parameters, the
workbench selection is set to those specified elements.

Known issues:
* Start from a diagram with a selection of elements which are displayed
in the diagram (they can be selected either in the diagram or through
the 'Explorer' tree). Then select either the diagram representation in
the 'Explorer' view, or the diagram background.
The selection gets set to the diagram representation, but quickly
evolves into an empty selection.
This does not occur when starting from a selection of elements that are
not shown in the diagram, or from an empty selection.
This behavior already occurred before, we should check whether this a
known issue in the tracker.
* When loading a URL with an opened representation and a selection of
elements, the selection is properly applied in the 'Explorer' view, but
not in the diagram. Expected behavior is that the nodes also get
'highlighted' as being part of the current selection.

Bug: eclipse-sirius#4376
Signed-off-by: Florent Latombe <[email protected]>
flatombe added a commit to flatombe/sirius-web-dev that referenced this issue Jan 23, 2025
@flatombe
[4376] Add current selection as a URL search parameter (WIP)
f6a04e0 
* When the workbench selection changes, the URL search parameters are
now automatically updated to encode the contents of the selection (id
and kind).
* Reversely, when resolving a URL with such search parameters, the
workbench selection is set to those specified elements.

Known issues:
* Start from a diagram with a selection of elements which are displayed
in the diagram (they can be selected either in the diagram or through
the 'Explorer' tree). Then select either the diagram representation in
the 'Explorer' view, or the diagram background.
The selection gets set to the diagram representation, but quickly
evolves into an empty selection.
This does not occur when starting from a selection of elements that are
not shown in the diagram, or from an empty selection.
This behavior already occurred before, we should check whether this a
known issue in the tracker.
* When loading a URL with an opened representation and a selection of
elements, the selection is properly applied in the 'Explorer' view, but
not in the diagram. Expected behavior is that the nodes also get
'highlighted' as being part of the current selection.

Bug: eclipse-sirius#4376
Signed-off-by: Florent Latombe <[email protected]>
flatombe added a commit to flatombe/sirius-web-dev that referenced this issue Jan 24, 2025
@flatombe
[4376] Add current selection as a URL search parameter
45b3287 
* When the workbench selection changes, the URL search parameters are
now automatically updated to encode the contents of the selection (id
and kind).
* Reversely, when resolving a URL with such search parameters, the
workbench selection is set to those specified elements.

Bug: eclipse-sirius#4376
Signed-off-by: Florent Latombe <[email protected]>
@pcdavid pcdavid linked a pull request Jan 27, 2025 that will close this issue
[4376] Add support for URLs to specify a selection of elements in the workbench #4461
Open
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: medium package: sirius web type: enhancement
Projects
None yet
Milestone
2025.2.0
1 participant
@sbegaudeau