Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide better user feedback when a Domain definition is invalid #4389

Open
pcdavid opened this issue Jan 7, 2025 · 0 comments
Open

Provide better user feedback when a Domain definition is invalid #4389

pcdavid opened this issue Jan 7, 2025 · 0 comments

Comments

@pcdavid
Copy link
Member

pcdavid commented Jan 7, 2025

We currently have some validation applying to domain definitions (see org.eclipse.sirius.components.domain.emf.DomainValidator), but when converting a domain definition into an actual EMF EPackage we are much more strict than what these validation rules check for.
Indeed, in DomainConverter we only consider domains which, once converted, do not have any error:

// Only return valid and safe EPackages
return ePackages.stream().filter(ePackage -> Diagnostician.INSTANCE.validate(ePackage).getSeverity() < Diagnostic.ERROR);

In practice this means even with no visible validation error, a domain definition can fail to be converted and thus not deployed/available, with zero feedback to the studio maker about what is wrong and needs to be fixed.

@pcdavid pcdavid changed the title Provide user feedback when a Domain definition is invalid Provide better user feedback when a Domain definition is invalid Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant