Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[editing] revise lsp editing implementation #15

Open
JanKoehnlein opened this issue May 5, 2020 · 0 comments
Open

[editing] revise lsp editing implementation #15

JanKoehnlein opened this issue May 5, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@JanKoehnlein
Copy link
Contributor

JanKoehnlein commented May 5, 2020

The current editing implementation based on LSP puts to much LSP magic on the client side. This leaks some abstractions, e.g. how to interpret traces. Into the bargain, it requires to relay language server requests between webview and extension, which was not necessary in Theia where there was no separate webview app.

  • Move as much as possible of the editing logic to the language server.
  • Use the new inline editing functionality of sprotty to edit rename labels
  • Maybe use new popup UI to edit cross-reference labels
  • Implement DeleteAction
@spoenemann spoenemann added the enhancement New feature or request label Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants