Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in the vscode.window.showInputBox API #14527

Open
safisa opened this issue Nov 26, 2024 · 1 comment
Open

Regression in the vscode.window.showInputBox API #14527

safisa opened this issue Nov 26, 2024 · 1 comment
Labels
bug bugs found in the application quick-open issues related to the quick-open

Comments

@safisa
Copy link
Contributor

safisa commented Nov 26, 2024

Bug Description:

Hi,
I think there is a regression in the vscode.window.showInputBox API, in the validateInput method. In the latest Theia versions, the validation error message is shown in a regular color style, but in an old Theia version (1.45), it was rendered in RED, which is the correct color.

Steps to Reproduce:

  1. use a vscode extension with a command that calls the vscode.window.showInputBox
  2. you should also implement the validateInput method in the showInputBox options object
  3. call the command in Theia that should trigger the validation error message
  4. the message will be rendered without the error styling

Screenshot of an old version:
error_old

Screenshot of the latest Theia version:
Screenshot 2024-11-26 at 14 03 02

Additional Information

  • Operating System: Mac
  • Theia Version: 1.55
@msujew
Copy link
Member

msujew commented Nov 26, 2024

Likely a regression from #13217. Most likely just some CSS changes required.

@msujew msujew added bug bugs found in the application quick-open issues related to the quick-open labels Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application quick-open issues related to the quick-open
Projects
None yet
Development

No branches or pull requests

2 participants