From 89ad13bc3c47deeac8988dfcfbcc352176bc883d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20M=C3=A4der?= Date: Wed, 12 Jun 2024 14:57:24 +0200 Subject: [PATCH 01/18] Enable browser tests on all platforms MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit fixes #13764 Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder --- .github/workflows/ci-cd.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci-cd.yml b/.github/workflows/ci-cd.yml index 4cf7f4872f462..b8b3a30630325 100644 --- a/.github/workflows/ci-cd.yml +++ b/.github/workflows/ci-cd.yml @@ -105,7 +105,7 @@ jobs: yarn test:theia - name: Test (browser) - if: matrix.tests != 'skip' && runner.os == 'Linux' + if: matrix.tests != 'skip' run: | xvfb-run -a yarn browser test From 689d2c98499a53cded00d9541fb9850d07a6d589 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20M=C3=A4der?= Date: Wed, 12 Jun 2024 15:59:10 +0200 Subject: [PATCH 02/18] Remove xvfb-run. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Thomas Mäder --- .github/workflows/ci-cd.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci-cd.yml b/.github/workflows/ci-cd.yml index b8b3a30630325..57739df2ee02a 100644 --- a/.github/workflows/ci-cd.yml +++ b/.github/workflows/ci-cd.yml @@ -107,7 +107,7 @@ jobs: - name: Test (browser) if: matrix.tests != 'skip' run: | - xvfb-run -a yarn browser test + yarn browser test - name: Test (electron) if: matrix.tests != 'skip' && runner.os == 'Linux' From e7110f81badd7c1748b6ef1229f74b2e256eeb30 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20M=C3=A4der?= Date: Wed, 12 Jun 2024 16:43:23 +0200 Subject: [PATCH 03/18] Download plugins on all platforms MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Thomas Mäder --- .github/workflows/ci-cd.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/ci-cd.yml b/.github/workflows/ci-cd.yml index 57739df2ee02a..21282d672860b 100644 --- a/.github/workflows/ci-cd.yml +++ b/.github/workflows/ci-cd.yml @@ -83,7 +83,6 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # https://github.com/microsoft/vscode-ripgrep/issues/9 - name: Download Plugins - if: runner.os == 'Linux' shell: bash run: | yarn -s download:plugins --rate-limit 3 From 47573d9969065e500adcafcd236afad58c36cae8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20M=C3=A4der?= Date: Thu, 13 Jun 2024 15:07:35 +0200 Subject: [PATCH 04/18] Update OSs and remove Node 16 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Thomas Mäder --- .github/workflows/ci-cd.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci-cd.yml b/.github/workflows/ci-cd.yml index 21282d672860b..3c88aef57bb2c 100644 --- a/.github/workflows/ci-cd.yml +++ b/.github/workflows/ci-cd.yml @@ -51,7 +51,7 @@ jobs: strategy: fail-fast: false matrix: - os: [windows-2019, ubuntu-22.04, macos-14] + os: [windows-latest, ubuntu-latest, macos-latest] node: [18.x, 20.x] runs-on: ${{ matrix.os }} From 18b68e51893c3517686e6a62b67f98b8b73a9093 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20M=C3=A4der?= Date: Fri, 21 Jun 2024 15:31:09 +0200 Subject: [PATCH 05/18] Update node-pty to 1.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Thomas Mäder --- yarn.lock | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/yarn.lock b/yarn.lock index 21d2692e9f2aa..7a38a396ec420 100644 --- a/yarn.lock +++ b/yarn.lock @@ -8974,10 +8974,10 @@ node-preload@^0.2.1: dependencies: process-on-spawn "^1.0.0" -node-pty@0.11.0-beta24: - version "0.11.0-beta24" - resolved "https://registry.yarnpkg.com/node-pty/-/node-pty-0.11.0-beta24.tgz#084841017187656edaf14b459946c4a1d7cf8392" - integrity sha512-CzItw3hitX+wnpw9dHA/A+kcbV7ETNKrsyQJ+s0ZGzsu70+CSGuIGPLPfMnAc17vOrQktxjyRQfaqij75GVJFw== +node-pty@^1.0.0: + version "1.0.0" + resolved "https://registry.yarnpkg.com/node-pty/-/node-pty-1.0.0.tgz#7daafc0aca1c4ca3de15c61330373af4af5861fd" + integrity sha512-wtBMWWS7dFZm/VgqElrTvtfMq4GzJ6+edFI0Y0zyzygUSZMgZdraDUMUhCIvkjhJjme15qWmbyJbtAx4ot4uZA== dependencies: nan "^2.17.0" From c0578613175cd9d1677deb7cd3ee887bd6f4d75b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20M=C3=A4der?= Date: Fri, 21 Jun 2024 17:22:30 +0200 Subject: [PATCH 06/18] Fix linux build MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Thomas Mäder --- .../native-webpack-plugin/src/native-webpack-plugin.ts | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/dev-packages/native-webpack-plugin/src/native-webpack-plugin.ts b/dev-packages/native-webpack-plugin/src/native-webpack-plugin.ts index 18ae43c186138..bcabc8fa58fb5 100644 --- a/dev-packages/native-webpack-plugin/src/native-webpack-plugin.ts +++ b/dev-packages/native-webpack-plugin/src/native-webpack-plugin.ts @@ -126,11 +126,7 @@ export class NativeWebpackPlugin { const dllFile = require.resolve('node-pty/build/Release/winpty.dll'); const targetDllFile = path.join(targetDirectory, 'winpty.dll'); await this.copyExecutable(dllFile, targetDllFile); - } else { - const sourceFile = require.resolve('node-pty/build/Release/spawn-helper'); - const targetFile = path.join(targetDirectory, 'spawn-helper'); - await this.copyExecutable(sourceFile, targetFile); - } + } } protected async copyTrashHelper(compiler: Compiler): Promise { From 58230660cb6bed362f02573e9c3fb6a88bf47fab Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20M=C3=A4der?= Date: Sun, 23 Jun 2024 08:48:11 +0200 Subject: [PATCH 07/18] Fix linter MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Thomas Mäder --- dev-packages/native-webpack-plugin/src/native-webpack-plugin.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev-packages/native-webpack-plugin/src/native-webpack-plugin.ts b/dev-packages/native-webpack-plugin/src/native-webpack-plugin.ts index bcabc8fa58fb5..0b0b7a24ec137 100644 --- a/dev-packages/native-webpack-plugin/src/native-webpack-plugin.ts +++ b/dev-packages/native-webpack-plugin/src/native-webpack-plugin.ts @@ -126,7 +126,7 @@ export class NativeWebpackPlugin { const dllFile = require.resolve('node-pty/build/Release/winpty.dll'); const targetDllFile = path.join(targetDirectory, 'winpty.dll'); await this.copyExecutable(dllFile, targetDllFile); - } + } } protected async copyTrashHelper(compiler: Compiler): Promise { From 2535070442829c5e2ee99ba4fec0c2b328309ee8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20M=C3=A4der?= Date: Sun, 23 Jun 2024 09:14:00 +0200 Subject: [PATCH 08/18] Fix rejections MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Thomas Mäder --- packages/process/src/node/terminal-process.spec.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/process/src/node/terminal-process.spec.ts b/packages/process/src/node/terminal-process.spec.ts index 9e73207078d40..51cffe889f705 100644 --- a/packages/process/src/node/terminal-process.spec.ts +++ b/packages/process/src/node/terminal-process.spec.ts @@ -40,9 +40,9 @@ describe('TerminalProcess', function (): void { it('test error on non existent path', async function (): Promise { const error = await new Promise((resolve, reject) => { const proc = terminalProcessFactory({ command: '/non-existent' }); - proc.onStart(reject); + proc.onStart(() => reject('process started')); proc.onError(resolve); - proc.onExit(reject); + proc.onExit(() => reject('process exited')); }); expect(error.code).eq('ENOENT'); @@ -59,7 +59,7 @@ describe('TerminalProcess', function (): void { const terminal = await new Promise((resolve, reject) => { const proc = terminalProcessFactory({ command, args }); proc.onExit(resolve); - proc.onError(reject); + proc.onError(() => reject('process errored')); }); expect(terminal.code).to.exist; @@ -68,9 +68,9 @@ describe('TerminalProcess', function (): void { it('test error on trying to execute a directory', async function (): Promise { const error = await new Promise((resolve, reject) => { const proc = terminalProcessFactory({ command: __dirname }); - proc.onStart(reject); + proc.onStart(() => reject('process started')); proc.onError(resolve); - proc.onExit(reject); + proc.onExit(() => reject('process exited')); }); if (isWindows) { From 1be85e0a88fda783ad8d19d1fde1147985051c03 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20M=C3=A4der?= Date: Sun, 23 Jun 2024 09:32:41 +0200 Subject: [PATCH 09/18] Reject with Error() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Thomas Mäder --- packages/process/src/node/terminal-process.spec.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/process/src/node/terminal-process.spec.ts b/packages/process/src/node/terminal-process.spec.ts index 51cffe889f705..0cdfab917fab7 100644 --- a/packages/process/src/node/terminal-process.spec.ts +++ b/packages/process/src/node/terminal-process.spec.ts @@ -40,9 +40,9 @@ describe('TerminalProcess', function (): void { it('test error on non existent path', async function (): Promise { const error = await new Promise((resolve, reject) => { const proc = terminalProcessFactory({ command: '/non-existent' }); - proc.onStart(() => reject('process started')); + proc.onStart(() => reject(new Error('process started'))); proc.onError(resolve); - proc.onExit(() => reject('process exited')); + proc.onExit(() => reject(new Error('process exited'))); }); expect(error.code).eq('ENOENT'); @@ -68,9 +68,9 @@ describe('TerminalProcess', function (): void { it('test error on trying to execute a directory', async function (): Promise { const error = await new Promise((resolve, reject) => { const proc = terminalProcessFactory({ command: __dirname }); - proc.onStart(() => reject('process started')); + proc.onStart(() => reject(new Error('process started'))); proc.onError(resolve); - proc.onExit(() => reject('process exited')); + proc.onExit(() => reject(new Error('process exited'))); }); if (isWindows) { From b7bd2512f42eb9fa376e989c746eb44b258043ad Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20M=C3=A4der?= Date: Sun, 23 Jun 2024 10:17:58 +0200 Subject: [PATCH 10/18] Don't emit 'started' if no pid is returned MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Thomas Mäder --- packages/process/src/node/terminal-process.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/process/src/node/terminal-process.ts b/packages/process/src/node/terminal-process.ts index f6879af71a08d..d4ff643ad89ef 100644 --- a/packages/process/src/node/terminal-process.ts +++ b/packages/process/src/node/terminal-process.ts @@ -150,7 +150,9 @@ export class TerminalProcess extends Process { options.options || {} ); - process.nextTick(() => this.emitOnStarted()); + if (process.pid !== undefined) { + process.nextTick(() => this.emitOnStarted()); + } // node-pty actually wait for the underlying streams to be closed before emitting exit. // We should emulate the `exit` and `close` sequence. From 860b7b4c01cdf364cf36a912e4dbfd370bc40b0d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20M=C3=A4der?= Date: Sun, 23 Jun 2024 11:37:20 +0200 Subject: [PATCH 11/18] Debug terminal process on unix MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Thomas Mäder --- packages/process/src/node/terminal-process.spec.ts | 1 + packages/process/src/node/terminal-process.ts | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/packages/process/src/node/terminal-process.spec.ts b/packages/process/src/node/terminal-process.spec.ts index 0cdfab917fab7..82650a6693798 100644 --- a/packages/process/src/node/terminal-process.spec.ts +++ b/packages/process/src/node/terminal-process.spec.ts @@ -40,6 +40,7 @@ describe('TerminalProcess', function (): void { it('test error on non existent path', async function (): Promise { const error = await new Promise((resolve, reject) => { const proc = terminalProcessFactory({ command: '/non-existent' }); + console.log(`pty is ${JSON.stringify(proc.debugString())}`); proc.onStart(() => reject(new Error('process started'))); proc.onError(resolve); proc.onExit(() => reject(new Error('process exited'))); diff --git a/packages/process/src/node/terminal-process.ts b/packages/process/src/node/terminal-process.ts index d4ff643ad89ef..23a27c599505d 100644 --- a/packages/process/src/node/terminal-process.ts +++ b/packages/process/src/node/terminal-process.ts @@ -135,6 +135,10 @@ export class TerminalProcess extends Process { this.inputStream = inputStream; } + debugString(): string { + return JSON.stringify(this.terminal); + } + /** * Helper for the constructor to attempt to create the pseudo-terminal encapsulating the shell process. * From 9d6a1f30e286b5cc96ff70961eb932dc224adf6c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20M=C3=A4der?= Date: Sun, 23 Jun 2024 15:22:48 +0200 Subject: [PATCH 12/18] Don't check for process started as it's not cross-platform MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Thomas Mäder --- packages/process/src/node/terminal-process.spec.ts | 2 -- 1 file changed, 2 deletions(-) diff --git a/packages/process/src/node/terminal-process.spec.ts b/packages/process/src/node/terminal-process.spec.ts index 82650a6693798..c6bdb61d43666 100644 --- a/packages/process/src/node/terminal-process.spec.ts +++ b/packages/process/src/node/terminal-process.spec.ts @@ -41,7 +41,6 @@ describe('TerminalProcess', function (): void { const error = await new Promise((resolve, reject) => { const proc = terminalProcessFactory({ command: '/non-existent' }); console.log(`pty is ${JSON.stringify(proc.debugString())}`); - proc.onStart(() => reject(new Error('process started'))); proc.onError(resolve); proc.onExit(() => reject(new Error('process exited'))); }); @@ -69,7 +68,6 @@ describe('TerminalProcess', function (): void { it('test error on trying to execute a directory', async function (): Promise { const error = await new Promise((resolve, reject) => { const proc = terminalProcessFactory({ command: __dirname }); - proc.onStart(() => reject(new Error('process started'))); proc.onError(resolve); proc.onExit(() => reject(new Error('process exited'))); }); From 7bf6a5b6e536a695c79641f1208978c1400c8b3f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20M=C3=A4der?= Date: Sun, 23 Jun 2024 15:54:56 +0200 Subject: [PATCH 13/18] Removing error case tests since they only test node-pty behavior. But that behavior is platform-dependent. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Thomas Mäder --- .../process/src/node/terminal-process.spec.ts | 46 ------------------- 1 file changed, 46 deletions(-) diff --git a/packages/process/src/node/terminal-process.spec.ts b/packages/process/src/node/terminal-process.spec.ts index c6bdb61d43666..c113339d74d22 100644 --- a/packages/process/src/node/terminal-process.spec.ts +++ b/packages/process/src/node/terminal-process.spec.ts @@ -34,54 +34,8 @@ beforeEach(() => { }); describe('TerminalProcess', function (): void { - this.timeout(20_000); - it('test error on non existent path', async function (): Promise { - const error = await new Promise((resolve, reject) => { - const proc = terminalProcessFactory({ command: '/non-existent' }); - console.log(`pty is ${JSON.stringify(proc.debugString())}`); - proc.onError(resolve); - proc.onExit(() => reject(new Error('process exited'))); - }); - - expect(error.code).eq('ENOENT'); - }); - - it('test implicit .exe (Windows only)', async function (): Promise { - const match = /^(.+)\.exe$/.exec(process.execPath); - if (!isWindows || !match) { - this.skip(); - } - - const command = match[1]; - const args = ['--version']; - const terminal = await new Promise((resolve, reject) => { - const proc = terminalProcessFactory({ command, args }); - proc.onExit(resolve); - proc.onError(() => reject('process errored')); - }); - - expect(terminal.code).to.exist; - }); - - it('test error on trying to execute a directory', async function (): Promise { - const error = await new Promise((resolve, reject) => { - const proc = terminalProcessFactory({ command: __dirname }); - proc.onError(resolve); - proc.onExit(() => reject(new Error('process exited'))); - }); - - if (isWindows) { - // On Windows, node-pty returns us a "File not found" message, so we can't really differentiate this case - // from trying to execute a non-existent file. node's child_process.spawn also returns ENOENT, so it's - // probably the best we can get. - expect(error.code).eq('ENOENT'); - } else { - expect(error.code).eq('EACCES'); - } - }); - it('test exit', async function (): Promise { const args = ['--version']; const exit = await new Promise((resolve, reject) => { From 8cd716fa092dfcb4e7ac3fd49c5260b0babfe28b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20M=C3=A4der?= Date: Sun, 23 Jun 2024 16:09:56 +0200 Subject: [PATCH 14/18] Fix compile error MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Thomas Mäder --- packages/process/src/node/terminal-process.spec.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/process/src/node/terminal-process.spec.ts b/packages/process/src/node/terminal-process.spec.ts index c113339d74d22..45c561bbbaef2 100644 --- a/packages/process/src/node/terminal-process.spec.ts +++ b/packages/process/src/node/terminal-process.spec.ts @@ -18,8 +18,7 @@ import * as process from 'process'; import * as stream from 'stream'; import { createProcessTestContainer } from './test/process-test-container'; import { TerminalProcessFactory } from './terminal-process'; -import { IProcessExitEvent, ProcessErrorEvent } from './process'; -import { isWindows } from '@theia/core/lib/common/os'; +import { IProcessExitEvent } from './process'; /** * Globals From 9e560476e20a557a2437238cf5cdf32fa3cf2278 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20M=C3=A4der?= Date: Sun, 23 Jun 2024 16:27:21 +0200 Subject: [PATCH 15/18] Remove test for non-existant failure. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Thomas Mäder --- packages/terminal/src/node/terminal-server.spec.ts | 5 ----- 1 file changed, 5 deletions(-) diff --git a/packages/terminal/src/node/terminal-server.spec.ts b/packages/terminal/src/node/terminal-server.spec.ts index 16e815d22d73c..7464ee1375e27 100644 --- a/packages/terminal/src/node/terminal-server.spec.ts +++ b/packages/terminal/src/node/terminal-server.spec.ts @@ -39,9 +39,4 @@ describe('TerminalServer', function (): void { const createResult = await terminalServer.create({ command: process.execPath, 'args': args }); expect(createResult).to.be.greaterThan(-1); }); - - it('test terminal create from non-existent path', async function (): Promise { - const createError = await terminalServer.create({ command: '/non-existent' }); - expect(createError).eq(-1); - }); }); From ddd8f17994a76ee108aa638cdc8fc8169d22f742 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20M=C3=A4der?= Date: Mon, 24 Jun 2024 10:56:27 +0200 Subject: [PATCH 16/18] Remove more "non-existent command" tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Thomas Mäder --- packages/task/src/node/task-server.slow-spec.ts | 6 ------ 1 file changed, 6 deletions(-) diff --git a/packages/task/src/node/task-server.slow-spec.ts b/packages/task/src/node/task-server.slow-spec.ts index 4c49bd6e8d272..d343f7df552d5 100644 --- a/packages/task/src/node/task-server.slow-spec.ts +++ b/packages/task/src/node/task-server.slow-spec.ts @@ -25,7 +25,6 @@ import * as https from 'https'; import { isWindows, isOSX } from '@theia/core/lib/common/os'; import { FileUri } from '@theia/core/lib/node'; import { terminalsPath } from '@theia/terminal/lib/common/terminal-protocol'; -import { expectThrowsAsync } from '@theia/core/lib/common/test/expect'; import { TestWebSocketChannelSetup } from '@theia/core/lib/node/messaging/test/test-web-socket-channel'; import { expect } from 'chai'; import URI from '@theia/core/lib/common/uri'; @@ -251,11 +250,6 @@ describe('Task server / back-end', function (): void { } }); - it('task using raw process can handle command that does not exist', async function (): Promise { - const p = taskServer.run(createProcessTaskConfig2('process', bogusCommand, []), wsRoot); - await expectThrowsAsync(p, 'ENOENT'); - }); - it('getTasks(ctx) returns tasks according to created context', async function (): Promise { const context1 = 'aContext'; const context2 = 'anotherContext'; From a6b513ad9500fbe3c0d9890b726f235abd9b436f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20M=C3=A4der?= Date: Thu, 28 Nov 2024 15:03:48 +0100 Subject: [PATCH 17/18] Update node-pty to newest beta version MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Thomas Mäder --- packages/process/package.json | 3 ++- yarn.lock | 15 ++++++++++----- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/packages/process/package.json b/packages/process/package.json index a45e4791fe73e..e3a1ea7558d9d 100644 --- a/packages/process/package.json +++ b/packages/process/package.json @@ -3,8 +3,9 @@ "version": "1.56.0", "description": "Theia process support.", "dependencies": { + "@theia/core": "1.56.0", - "node-pty": "0.11.0-beta24", + "node-pty": "1.1.0-beta27", "string-argv": "^0.1.1", "tslib": "^2.6.2" }, diff --git a/yarn.lock b/yarn.lock index 7a38a396ec420..0be0eaa71fd4a 100644 --- a/yarn.lock +++ b/yarn.lock @@ -8902,6 +8902,11 @@ node-addon-api@^7.0.0: resolved "https://registry.yarnpkg.com/node-addon-api/-/node-addon-api-7.1.1.tgz#1aba6693b0f255258a049d621329329322aad558" integrity sha512-5m3bsyrjFWE1xf7nz7YXdN4udnVtXK6/Yfgn5qnahL6bCkf2yKt4k3nuTKAtT4r3IG8JNR2ncsIMdZuAzJjHQQ== +node-addon-api@^7.1.0: + version "7.1.1" + resolved "https://registry.yarnpkg.com/node-addon-api/-/node-addon-api-7.1.1.tgz#1aba6693b0f255258a049d621329329322aad558" + integrity sha512-5m3bsyrjFWE1xf7nz7YXdN4udnVtXK6/Yfgn5qnahL6bCkf2yKt4k3nuTKAtT4r3IG8JNR2ncsIMdZuAzJjHQQ== + node-api-version@^0.1.4: version "0.1.4" resolved "https://registry.yarnpkg.com/node-api-version/-/node-api-version-0.1.4.tgz#1ed46a485e462d55d66b5aa1fe2821720dedf080" @@ -8974,12 +8979,12 @@ node-preload@^0.2.1: dependencies: process-on-spawn "^1.0.0" -node-pty@^1.0.0: - version "1.0.0" - resolved "https://registry.yarnpkg.com/node-pty/-/node-pty-1.0.0.tgz#7daafc0aca1c4ca3de15c61330373af4af5861fd" - integrity sha512-wtBMWWS7dFZm/VgqElrTvtfMq4GzJ6+edFI0Y0zyzygUSZMgZdraDUMUhCIvkjhJjme15qWmbyJbtAx4ot4uZA== +node-pty@1.1.0-beta27: + version "1.1.0-beta27" + resolved "https://registry.yarnpkg.com/node-pty/-/node-pty-1.1.0-beta27.tgz#08a76876d345a03dd181f0b81fa7eb26e31b39b3" + integrity sha512-r0nRVgunspo/cBmf/eR+ultBrclxqldaL6FhiTLEmC4VcyKJxhluRK5d8EtbHYPLt8DqPKMnCakJDxreQynpnw== dependencies: - nan "^2.17.0" + node-addon-api "^7.1.0" node-releases@^2.0.14: version "2.0.14" From 39281f1603330781ed3ce98eb7c668fd39c93072 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20M=C3=A4der?= Date: Thu, 28 Nov 2024 16:35:17 +0100 Subject: [PATCH 18/18] Random change to poke Github MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Thomas Mäder --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index d9bfb996c16bc..fcd00ed8afffd 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,8 @@ - [Previous Changelogs](https://github.com/eclipse-theia/theia/tree/master/doc/changelogs/) +Poking Github + ## 1.56.0 - 11/28/2024 - [ai] added support for users to specify custom request settings, model, and optionally provider-specific [#14535](https://github.com/eclipse-theia/theia/pull/14535)