Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set-version doesn't update launcher name in product file #4068

Open
bllngr opened this issue Jul 30, 2024 · 2 comments
Open

set-version doesn't update launcher name in product file #4068

bllngr opened this issue Jul 30, 2024 · 2 comments

Comments

@bllngr
Copy link

bllngr commented Jul 30, 2024

Steps to reproduce

  • In a project, make sure the launcher name in the product file includes the project version, e.g. My Product 1.2.3
  • Run mvn clean package and make sure the created launcher includes the version number, eg My Product 1.2.3.exe on Windows
  • Run mvn org.eclipse.tycho:tycho-versions-plugin:set-version -DnewVersion=2.0.0
  • Run mvn clean package and check the name of the created launcher

Expected result

The launcher name contains the new version. i.e. My Product 2.0.0.exe on Windows

Actual result

The version in the launcher name is not updated and stays on the old version, i.e. My Product 1.2.3.exe on Windows

Excerpts

<product name=My Product" uid="my-product" id="my.product" application="org.eclipse.e4.ui.workbench.swt.E4Application" 
   version="1.2.3" includeLaunchers="true">

   <!-- ... -->

   <launcher name="My Product 1.2.3">
   </launcher>

   <!-- ... -->

</product>
@laeubi
Copy link
Member

laeubi commented Jul 30, 2024

I'm not sure this is something one can expect, how should Tycho know it is "the version" and not an arbitrary string?

@laeubi
Copy link
Member

laeubi commented Aug 2, 2024

It might be more valuable to support property replacement in the launcher name so it can become:

<launcher name="My Product ${project.version}">

or

<launcher name="My Product ${product.version}">

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants