-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check usage of quoted strings instead of multiline strings in some Xtend tests #2999
Comments
On a Windows computer you get the full list easily by running a full clean build and check the Git-Staging view for changed files, which gives me:
But looking at the affected test cases, I don't think the usage of quoted string was on purpose and not by accident, because the strings using standard java quotes contain metacharacters for Xtend multi line strings like for example
I can escape |
Thanks for the analysis @HannesWell! @szarnekow do you think we can turn those tests into multiline strings? |
Your welcome. I think I found a solution based on this answer: https://groups.google.com/g/xtend-lang/c/bVZ0nKmQGAI If you are fine with this, I can create a PR this evening. |
But that doesn't escape However, let's postpone this for the moment. |
It does if If wrap it into a tag with a literal string, like But this becomes a bit cumbersome if there are multiple such elements in a template. So I'm not sure if it would be 'better' to migrate them directly to Java Text-Blocks. |
I think this can be closed now that #3004 has been merged |
Thanks a lot for fixing this. It was always annoying to sort-out unrelated changes in git on Windows. |
See #2993 (comment)
The text was updated successfully, but these errors were encountered: