[#2318] Clean AllAssociation when removing field with active annotation #2776
+195
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see eclipse-xtext#2318 Signed-off-by: Didier Vojtisek <[email protected]>
fixes eclipse-xtext#2318 Signed-off-by: Didier Vojtisek <[email protected]>
dvojtise
changed the title
szarnekow
reviewed
Aug 10, 2023
| @@ -1320,6 +1320,8 @@ class JvmFieldDeclarationImpl extends JvmMemberDeclarationImpl<JvmField> impleme | |||
| } | |||
|
|
|||
| override remove() { | |||
| compilationUnit.jvmModelAssociator.removeAllAssociation(delegate.type) | |||
There was a problem hiding this comment.
There might be other removevAllAssociations(..) missing in this file, no?
There was a problem hiding this comment.
yes probably on other kind of remove
but since it make silently crash other remove (see the new failed test. after the first remove. the other ones aren't processed)
I'm not sure anymore that it should be done that way
I must admit I don't master xtend internal structures and I'm not efficient in finding a solution for cleaning these structures on all remove situations
There was a problem hiding this comment.
I'll give it a stab later this week.
|
can you also have a look at the failing test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes to #2318
testresourceStorageWritefails if the fix below isn't applied)org/eclipse/xtend/core/macro/declaration/JvmBasedDeclarations.xtend