Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model resolution seems rather unused #181

Open
clonker opened this issue Oct 24, 2023 · 1 comment
Open

model resolution seems rather unused #181

clonker opened this issue Oct 24, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@clonker
Copy link

clonker commented Oct 24, 2023

The virtual resolution method on a cloe Model does not really influence the simulation step size but rather just returns it (or does it?). In any case the docstring indicates IMO that it would effect the simulation loop integration step size. I think the docstring should be updated or perhaps the method even removed/replaced with a non-virtual counterpart that returns the configured value.

@cassava
Copy link
Contributor

cassava commented Oct 27, 2023

This is true: we don't actually have the logic in place to respect this.

But we wanted to put it in the API because we anticipated it. We have been waiting for someone to need it.

@cassava cassava modified the milestones: 0.X, 0.23.0 Dec 6, 2023
@cassava cassava self-assigned this Dec 6, 2023
@cassava cassava added the bug Something isn't working label Dec 6, 2023
@cassava cassava modified the milestones: 0.23.0, 0.24.0 Apr 22, 2024
@cassava cassava modified the milestones: 0.24.0, 0.25.0 May 6, 2024
@cassava cassava removed this from the 0.25.0 milestone Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants