Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mirror] Stops mirroring versions when one fails validation #923

Open
alvsan09 opened this issue May 29, 2024 · 2 comments · May be fixed by #942
Open

[Mirror] Stops mirroring versions when one fails validation #923

alvsan09 opened this issue May 29, 2024 · 2 comments · May be fixed by #942

Comments

@alvsan09
Copy link
Contributor

The current logic when mirroring versions stops the loop when a version fails,
This prevents publishing of versions that may pass the validation, and if the failure happen of the oldest version,
the new ones will not get published.

The relevant line of code is at:

openvsx/server/src/main/java/org/eclipse/openvsx/mirror/MirrorExtensionService.java

Line 146 in e388b7e

throw t;

An example is: BroadcomMFD.ccf
The validation error below impacts earlier versions of it, but with the current logic non of the versions are mirrored.

2024-05-28T23:42:36.447Z ERROR 1 --- [ool-10-thread-2] o.e.o.m.DataMirrorJobRequestHandler : failed to mirror BroadcomMFD.ccf

org.eclipse.openvsx.util.ErrorResultException: Invalid URL in field 'homepage': .
hoangphamEclipse added a commit to hoangphamEclipse/openvsx that referenced this issue Jun 11, 2024
@hoangphamEclipse
Continue mirror extension versions even if one fails
5fe0984 
Currently, the OpenVSX server stops mirroring extension version if one of the
versions failed to be mirrored. This commit logs the mirror failure instead of
throwing an error.

Fixes eclipse#923.
@hoangphamEclipse hoangphamEclipse linked a pull request Jun 11, 2024 that will close this issue
Open
@amvanbaren
Copy link
Contributor

@akosyakov I thought there was a reason why we stop mirroring versions when one fails validation, but it's been a while. Do you know why?

hoangphamEclipse added a commit to hoangphamEclipse/openvsx that referenced this issue Jun 13, 2024
@hoangphamEclipse
Continue mirror extension versions even if one fails
32caeb7 
Currently, the OpenVSX server stops mirroring extension version if one of the
versions failed to be mirrored. This commit logs the mirror failure instead of
throwing an error.

Fixes eclipse#923.
hoangphamEclipse added a commit to hoangphamEclipse/openvsx that referenced this issue Jun 14, 2024
@hoangphamEclipse
Continue mirror extension versions even if one fails
bcad29f 
Currently, the OpenVSX server stops mirroring extension version if one of the
versions failed to be mirrored. This commit logs the mirror failure instead of
throwing an error.

Fixes eclipse#923.
@akosyakov
Copy link
Member

akosyakov commented Jun 20, 2024 •
edited
Loading

I cannot remember already sorry, but we are using our fork for last year and have not upgraded, not sure how would it work.

Maybe it was to avoid inconsistency which could lead to problems on the next sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Continue mirror extension versions even if one fails hoangphamEclipse/openvsx
3 participants
@akosyakov @amvanbaren @alvsan09