-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SWTChart should use MenuManager #84
Comments
For example under Linux it is extremely annoying: Right clicking on a (non focused) Chart open the poup-menu but immediately closes the menu (now the chart has gained focus) and the user must click once again. |
That's a good idea. Could you provide a small code example, so that we are able to evaluate using the JFace menu manager. |
@laeubi I can't see that you have provided a JFace menu manager example or better a PR to address this issue. When closing issues without code contribution, please write a comment. Did the problem disappear? |
Currently SWTChart uses a custom made framework to add/remove/mange Context menus.
JFace already offers a MenuManger that is more flexible using actions instead of plain listeners and manages adding/removal more gracefully, it also allows deeper nesting, enable/disable on demand and dynamic menu contributions.
Currently the SWTChart implementation suffers from most of these features so it would be best to switch over to the JFace Menumanager as it also allows more smooth integration with other components.
The text was updated successfully, but these errors were encountered: