Async Validation with Ajv #1386
Draft
+8,821
−6,025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a way to init JSON Forms with an async validation execution. This is necessary to support async-marked schemas for which the user can register async validation functions in Ajv. * Introduce separate init actions with and without validation * Offer a thunk which executes the init action without validation and sets the errors afterwards once Ajv finished validation
* Init all examples with async validation * Configure person example to be async
|
Thank you, Stefan! |
eneufeld
requested changes
Jun 13, 2019
|
|
||
| return error; | ||
| }); | ||
| export const sanitizeErrors = (validator: ValidateFunction, data: any) => { |
There was a problem hiding this comment.
It would be better to have a return type
| } | ||
| }; | ||
|
|
||
| export const asyncSanitizeErrors = (validator: ValidateFunction, data: any) => { |
There was a problem hiding this comment.
It would be better to have a return type
sdirix
force-pushed
the
master
branch
2 times, most recently
from
8bd14c2
to
e9946ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (draft) PR introduces the concept of async validation with Ajv for #1347.
This concept is introduced next to (instead of replacing) synchronous validation. To implement the functionality we use redux-thunk to allow for chained async actions, however redux-thunk is only necessary when the user wants to use async-marked schemas.
This (draft) PR contains the thunk for JSON Forms initialization with an async Ajv validation run, see
Actions.initAsyncValidation. The (currently) last commit enables the async behavior for all examples, however only the person example is actually marked async (the remaining examples use a fallback).Open tasks:
SET_AJVandUPDATE_DATA.