Kill jobs on workers #147
Merged
Kill jobs on workers #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbiavati
reviewed
Jan 16, 2025
There was a problem hiding this comment.
Nice implementation.
However, some times I have seen duplicated request_uid running on the scheduler (not often, but from time to time)
So an handling for errors should be in place to avoid crashes of the broker.
Consider for instance the race condition of a job finishing by itself just before sending the kill command
…es and improve error logging
|
I've updated the PR to address multiple processes and no processes cases |
gbiavati
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.