Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When parsing dates '-' character is deleted #14

Open
keithkade opened this issue Jan 28, 2014 · 8 comments
Open

When parsing dates '-' character is deleted #14

keithkade opened this issue Jan 28, 2014 · 8 comments
Assignees
Labels

Comments

@keithkade
Copy link
Member

example: http://www.metmuseum.org/Collections/search-the-collections/488690

Other special characters are ok: http://www.moma.org/collection/browse_results.php?criteria=O%3AAD%3AE%3A28723&page_number=1&template_id=1&sort_order=1

@quyin
Copy link
Member

quyin commented Jan 29, 2014

can you also give the meta-metadata field that is involved, with type info
and full xpath?

Best Regards,
Yin Qu (屈垠)

On Tue, Jan 28, 2014 at 5:45 PM, Kade Keith [email protected]:

example:
http://www.metmuseum.org/Collections/search-the-collections/488690

Other special characters are ok:
http://www.moma.org/collection/browse_results.php?criteria=O%3AAD%3AE%3A28723&page_number=1&template_id=1&sort_order=1


Reply to this email directly or view it on GitHubhttps://github.com//issues/14
.

@keithkade
Copy link
Member Author

scalar name="year" xpath="(//dd[preceding-sibling::dt[contains(text(),'Date:')]])[1]"/

@quyin quyin added the bug label Feb 7, 2014
@quyin
Copy link
Member

quyin commented Sep 18, 2014

The Met museum wrapper might not be working correctly now. @keithkade could you please check? Please also check if the bug still persists after fixing the wrapper, and update in this thread. Thanks!

@keithkade
Copy link
Member Author

currently updating the wrapper. the bug is still there

@quyin
Copy link
Member

quyin commented Sep 22, 2014

is this field of type "String" or "Date"?

if it is "Date", it's possible that the date format is parsed into a java.util.Date object, and serialized into a slightly different format (without dashes) -- which means it's not a bug but a feature. but we might want to change the serialized date format if the use case requires.

@keithkade
Copy link
Member Author

it is a string.

inherits from artwork.xml which has following definition:
scalar name="year" comment="Year the work was created." scalar_type="String"

@quyin
Copy link
Member

quyin commented Sep 22, 2014

that's weird. when you are done with the wrapper please reassign this to me and I'll take a look.

@keithkade keithkade assigned quyin and unassigned keithkade Sep 22, 2014
@quyin
Copy link
Member

quyin commented Mar 26, 2015

the dash character is unicode. so I suspect this is another manifestation of the unicode issue we were having.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants