included taraxl sdk header files do not correspond with the header files shipped with taraxl

[patriklabs]

Hi i have downloaded and installed TaraXL sdk and tried compiling taraxl-ros-package, however i get the following error message

'''
[100%] Linking CXX executable /home/nvidia/catkin_ws/devel/lib/taraxl_ros_package/taraxl_ros_package
CMakeFiles/taraxl_ros_package.dir/src/TaraXLRos.cpp.o: In function taraxlros::rosPublish()': TaraXLRos.cpp:(.text+0x418): undefined reference to TaraXLSDK::TaraXLDepth::getMaxDisparity(int&)'
TaraXLRos.cpp:(.text+0x438): undefined reference to TaraXLSDK::TaraXLDepth::getMaxDisparity(int&)' CMakeFiles/taraxl_ros_package.dir/src/TaraXLRos.cpp.o: In function taraxlros::disparityPublisher(boost::shared_ptr<stereo_msgs::DisparityImage_<std::allocator > >&, cv::Mat)':
TaraXLRos.cpp:(.text+0xfa8): undefined reference to TaraXLSDK::TaraXLDepth::getMaxDisparity(int&)' CMakeFiles/taraxl_ros_package.dir/src/TaraXLRos.cpp.o: In function taraxlros::dynamicReconfCallback(taraxl_ros_package::taraxlrosConfig&, unsigned int)':
TaraXLRos.cpp:(.text+0x1420): undefined reference to TaraXLSDK::TaraXLDepth::getMaxDisparity(int&)' TaraXLRos.cpp:(.text+0x146c): undefined reference to TaraXLSDK::TaraXLDepth::getMaxDisparity(int&)'
CMakeFiles/taraxl_ros_package.dir/src/TaraXLRos.cpp.o:TaraXLRos.cpp:(.text+0x14b8): more undefined references to TaraXLSDK::TaraXLDepth::getMaxDisparity(int&)' follow CMakeFiles/taraxl_ros_package.dir/src/TaraXLRos.cpp.o: In function taraxlros::getCalib()':
TaraXLRos.cpp:(.text+0x3c10): undefined reference to TaraXLSDK::TaraXLCam::getResolution(TaraXLSDK::Resolution&)' TaraXLRos.cpp:(.text+0x3c40): undefined reference to TaraXLSDK::TaraXLCam::getCalibrationParameters(cv::Mat&, cv::Mat&, TaraXLSDK::CalibrationParams&, TaraXLSDK::CalibrationParams&, TaraXLSDK::CalibrationParams&, TaraXLSDK::CalibrationParams&)'
collect2: error: ld returned 1 exit status
taraxl-ros-package/taraxl_ros_package/CMakeFiles/taraxl_ros_package.dir/build.make:483: recipe for target '/home/nvidia/catkin_ws/devel/lib/taraxl_ros_package/taraxl_ros_package' failed
make[2]: *** [/home/nvidia/catkin_ws/devel/lib/taraxl_ros_package/taraxl_ros_package] Error 1
CMakeFiles/Makefile2:2217: recipe for target 'taraxl-ros-package/taraxl_ros_package/CMakeFiles/taraxl_ros_package.dir/all' failed
make[1]: *** [taraxl-ros-package/taraxl_ros_package/CMakeFiles/taraxl_ros_package.dir/all] Error 2
Makefile:140: recipe for target 'all' failed
make: *** [all] Error 2
Invoking "make -j6 -l6" failed
'''

Looking into the header files shipped with taraxl the functions above are missing, while they are included in the header files that comes with the taraxl-ros-package. This causes the issues since they are no longer implemented in taraxl-sdk and included in the generated lib file.

A possible fix for this would be to update the code in the package to align with the updated sdk and instead of including a copy of the header files directly, they can be included in the cmake file.

Best
Patrik