Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: /my_files/{sub_path} returns relative path #56

Open
moi90 opened this issue Feb 16, 2023 · 6 comments · May be fixed by #59
Open

API: /my_files/{sub_path} returns relative path #56

moi90 opened this issue Feb 16, 2023 · 6 comments · May be fixed by #59

Comments

@moi90
Copy link
Contributor

moi90 commented Feb 16, 2023 •
edited
Loading

I'm using /my_files/{sub_path} to see if a file is already uploaded (in order to not upload it again), in preparation for a subsequent import (file_import/{project_id}).

When I actually upload the file, the returned filename is absolute (e.g. /tmp/ecotaxa_user.XXX/XXX/LOKI_46-24hours_01.zip and file_import/{project_id} works.

However, /my_files/{sub_path} returns a path relative to the user directory:

{
  'path': 'XXX',
  'entries': [{'name': 'LOKI_46-24hours_01.zip', 'type': 'F', 'size': 0, 'mtime': '2023-02-16 19:06:50.901954'}]
}

Therefore, file_import/{project_id} does not work, because it assumes absolute paths or paths relative to the common import directory.

No such file or directory: '/ecotaxa_import_area/XXX/LOKI_46-24hours_01.zip'

I think for the /my_files/{sub_path} endpoint to be useful, it should return absolute paths.
@moi90 moi90 mentioned this issue Feb 16, 2023
Closed
moi90 added a commit to moi90/ecotaxa_back that referenced this issue Feb 16, 2023
@moi90
Make /my_files/ return absolute paths
33de13f 
Fixes ecotaxa#56.
@moi90 moi90 linked a pull request Feb 16, 2023 that will close this issue
Open
@grololo06
Copy link
Member

Hello, I think that security "rules" forbid the disclosure of real paths when possible, so it should be fixed the other way, i.e. the upload should return a relative path. There is ongoing work around [up|down]load and this would allow more flexibility, e.g. having different storage places depending on users, etc.

@grololo06
Copy link
Member

The idea as of today is to offer a Google Drive-like storage per user.

@moi90
Copy link
Contributor Author

moi90 commented Feb 17, 2023

Yes, I agree that it is not very safe to disclose real server paths. Maybe a different kind of identifier would work? Like user:path/relative/to/user/dir and common:path/relative/to/common/dir? (Then one wouldn't lose the ability to select different storage locations.)

What do you mean by "google-drive-like"?

What is the time horizon for "doing it the proper way"? Could you maybe apply my pull request as a short-term fix until the issue is resolved properly? I would say that /my_files is pretty much broken at the moment.

grololo06 added a commit that referenced this issue Feb 18, 2023
@grololo06
#56: Example of my_files usage.
a0f96d9
@grololo06
Copy link
Member

Hello,
In fact file_import works as well for my_files entries, but it's dirty. See here:

ecotaxa_back/QA/py/tests/test_my_files.py

Line 72 in a0f96d9

# Import the file with the right path
for composing a 'working' path.

In the future implementation, there will just be no access to absolute directory of any kind, so it will be easier.

Your idea about prefixes looks good to me: #60 It could probably be implemented right now, even if only used in UT.

The release planning is not fixed, but I don't think you're blocked for any purpose, but feel free to tell me otherwise.

@moi90 moi90 mentioned this issue Feb 20, 2023
Open
@moi90
Copy link
Contributor Author

moi90 commented Feb 20, 2023

Thanks for this code example! So basically, I have to construct source_path myself on the client side: source_path = "/tmp/ecotaxa_user.{CREATOR_USER_ID}/{TAG}/{DEST_FILE_NAME}".

#60 It could probably be implemented right now, even if only used in UT.

What does UT mean?

You're right, this issue does not block me, I will work around it.

@grololo06
Copy link
Member

Thanks for this code example! So basically, I have to construct source_path myself on the client side: source_path = "/tmp/ecotaxa_user.{CREATOR_USER_ID}/{TAG}/{DEST_FILE_NAME}".

As of today, yes.

#60 It could probably be implemented right now, even if only used in UT.

What does UT mean?

Unit Test

You're right, this issue does not block me, I will work around it.

Oki great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make /my_files/ return absolute paths moi90/ecotaxa_back
2 participants
@moi90 @grololo06