Read Later Context option not showing up

[zernyu]

Using 1.5.1 and Chrome 10.0.648.45 dev. Every context menu option shows up except for "Read Later". I've tried switching around the settings and hitting save and restarting the browser, but it doesn't fix it.

[edgarjs]

And when you go back to options, the checkbox is still selected?

[zernyu]

Yes, the checkbox is still selected.

Read Later

Text view

Go to unread

Go to starred

Go to archive

Only "Read Later" is checked, yet it doesn't show up in my context menu. :/

[edgarjs]

Can you inspect the saved options doing this and tell me the values that are in the table (of course ignore username and password).

Right click on the extension icon, then choose "Manage extensions...", then on the top right click "Developer mode" and then under the Instachrome row, click "background.html" and a small window should pop up. Then choose "Resources" on the top tabs, and then expand "LocalStorage" on the side bar, and click the item with the random numbers and letters. It should show all the option values for the extension. What does it say in "cx_read_later" ?

[PJnes]

Was having the same problem. Quick poke around in background.js and I found that the function was

if($.db('cx_read_later') === '1') {
    chrome.contextMenus.create({
        title: 'Read later (send to instapaper)',
        contexts: ['link'],
        onclick: function(data, tab) {
            readLater({id: tab.id, url: data.linkUrl}, null, 'contextual');
        }
    });
}

when it should have been

if($.db('cx_read_later') === '1') {
    chrome.contextMenus.create({
        title: 'Read later (send to instapaper)',
        contexts: ['page'],
        onclick: function(data, tab) {
            readLater({id: tab.id, url: data.pageUrl}, null, 'contextual');
        }
    });
}

Not on a machine with Git at the moment or I'd fork the fix.

[edgarjs]

Ah I see the problem then. I implemented the Read Later context option for links only. People was asking for save pages without opening, so you need to click a link for the menu option to show up. But you're right, it makes sense to have the option for the current page as well. I saw your pull request, will add it but with an extra configurable option for that. Thanks.

[zernyu]

Oooh.. I didn't know that was how it functions! A little note in the options page could be helpful. :)