Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positives from comparing struct names with different astId #8

Open
glmaljkovich opened this issue Oct 19, 2021 · 0 comments

Comments

@glmaljkovich
Copy link
Collaborator

When the storage layout is generated each Type of kind struct or array gets an astId appended to its name (i.e. t_struct(Delegation)11437_storage where the astId is 11437). As a codebase grows the astId for a given struct might change and that throws off our typeHash calculation, generating false positives.

We need to trim those astId from all types and type definitions to avoid this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant