Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine RawCodec and Queryable? #40

Open
CodesInChaos opened this issue Aug 17, 2020 · 1 comment
Open

Combine RawCodec and Queryable? #40

CodesInChaos opened this issue Aug 17, 2020 · 1 comment

Comments

@CodesInChaos
Copy link
Contributor

What is the benefit of having RawCodec in addition to Queryable? It has a subset of the functionality, but for every type you'd want to implement RawCodec for, you'd also want to implement Queryable for. (It's also never used as trait, so if there are exceptions, you could just use a free function as helper)

@tailhook
Copy link
Contributor

tailhook commented Aug 17, 2020

Well, yes, it looks like ugly design artifact. I have mixed feeling, though: Queryable is meant to mean a high level thing, i.e. something that you can query from the database, so using it from the inside of Codec sounds a bit weird.

@tailhook tailhook mentioned this issue Aug 17, 2020
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants