Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable unenroll option for paid course #604

Open
wants to merge 2 commits into
base: develop-koa
Choose a base branch
from

Conversation

Waleed-Mujahid
Copy link

Description

Paid courses unenrollment shows refund text currently and when user tries to enroll again it gives error saying "already enrolled". This PR updates the flow the disallow users from unenrolling from paid courses

Jira

https://edlyio.atlassian.net/browse/EDLY-7231

@manan-memon
Copy link

Can't we use any other endpoint to retrieve this information? Why do we need to create a new one?

@Waleed-Mujahid
Copy link
Author

Waleed-Mujahid commented Dec 23, 2024

Can't we use any other endpoint to retrieve this information? Why do we need to create a new one?

@manan-memon The endpoint previously being used was course_run_refund_status but that one also returns based on if the refund expiry date has passed and give appropriate response if user can no longer refund the course. This API simplifies the logic of course_run_refund_status and only checks if user has paid for a course and returns true. There is no other to link a payment to a user and course

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants