Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unifying and extending #29

Open
rosejn opened this issue Jan 21, 2022 · 0 comments
Open

Unifying and extending #29

rosejn opened this issue Jan 21, 2022 · 0 comments

Comments

@rosejn
Copy link

rosejn commented Jan 21, 2022

Hi,
Thanks for writing this library. We needed to switch to binary data transmission for an IOT project involving lots of real-time data, and this helped a lot. In order to create a full solution that we could use with Sente over websockets to transmit binary typed arrays from a Clojure server to a Clojurescript web app, I needed to use both this library as well as the msgpack-cljs here: https://github.com/pkcsecurity/msgpack-cljs, which credits you for doing the initial hard work. Well, I'm now unifying them both to share common interfaces and extension points. This lets us program against them identically, and more importantly, I'd like to test and verify that we have shared Clojure types, typed arrays, dates and times, etc., which work seamlessly between server and client. To do this I've pulled the cljs lib into clojure-msgpack, and then done some refactoring of both. I wanted to reach out to you to see if you are still interested in maintaining this library and accepting this update, or whether I should just publish a new library? If so, I'm happy to give you guys all the credit for doing the hard work, and it would be great if you could link to the new library so we don't have a confusing set of libs for the Clojure community to have to navigate.

My current work is here: https://github.com/rosejn/clojure-msgpack/tree/cljc and we are using this live today so it's up and running. I've still got work to do to make the cljs code extensible using the same macro as this library, but I already extended both sides to support the full set of typed arrays. I'll go ping the other author as well, and I look forward to your reply. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant