Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library grid view uses table for presentation. #2714

Open
gautierchomel opened this issue Dec 13, 2024 · 1 comment · May be fixed by #2705
Open

Library grid view uses table for presentation. #2714

gautierchomel opened this issue Dec 13, 2024 · 1 comment · May be fixed by #2705

Comments

@gautierchomel
Copy link
Member

gautierchomel commented Dec 13, 2024

We should probably use role=presentation on the table elements to make sure AT users don't get lost looking for unexisting columns.
image

We should test side effects before merging such change

@gautierchomel gautierchomel changed the title Library grid view uses table for presentation (and therefore souhld Library grid view uses table for presentation. Dec 13, 2024
@gautierchomel
Copy link
Member Author

<table role="table" class="allBook_table" style="display: table">
  <tbody
    role="rowgroup"
    class="allBook_table_body"
    id="publicationsTableBody"
    style="display: grid"
  >
    <tr>
      <td>
        <div class="publication_wrapper">
          <a
            title="Le diable au cœur - Marc Ivry"
            class="publication_main_container"
            tabindex="0"
            ><img
              tabindex="-1"
              class="cover_img"
              role="presentation"
              alt=""
              aria-hidden="true"
              src="store://ca038eb5-d719-4d34-8441-dd5d46a0d259/cover.jpg"
            />
            <div class="gradient"></div>
            <div class="publication_title_wrapper">
              <p aria-hidden="true" class="publication_title">
                Le diable au cœur
              </p>
              <p aria-hidden="true" class="publication_authors">Marc Ivry</p>
            </div></a
          >
          <div class="publication_infos_wrapper">
            <div class="publication_infos">
              <div
                style="
                  display: flex;
                  align-items: center;
                  gap: 10px;
                  flex-wrap: wrap;
                "
              ></div>
              <div
                style="
                  display: flex;
                  align-items: end;
                  height: 50px;
                  width: 100%;
                  justify-content: space-between;
                "
              >
                <span class="button_secondary_blue">EPUB</span
                ><button
                  class="dropdown_trigger"
                  type="button"
                  aria-haspopup="dialog"
                  aria-expanded="false"
                  aria-controls="radix-:r5v:"
                  data-state="closed"
                >
                  <svg viewBox="0 0 24 24">
                    <title>Menu (Le diable au cœur)</title>
                    <use xlink:href="#menu"></use>
                  </svg>
                </button>
              </div>
            </div>
          </div>
        </div>
      </td>
    </tr>

@arthur-lemeur arthur-lemeur linked a pull request Dec 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant