enhance preset notification on configChanged #2686
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each new imported publication inherit from the default global readerConfig settings, (they're a kind of fork of the readerConfig). Each publication become independent, the user setting up the local readerConfig attached to the publication and can apply this readerConfig settings to a global registry called defaultReaderConfig. It's a global preset across the entire publication. When an user want to apply this global configuration to his current publication, he need to call back from the reader navigation preset menu. This is the new Thorium 3.1 behavior, there are an independent global readerConfig preset.
Now, I make the observation that the preset menu section is not very clear at all. It's difficult to call back and apply to the global readerConfig preset registry. We can't know when a divergence appears between the current local readerConfig publication and the global readerConfig preset. So that we propose Arthur and I is a discrete notification when there is a mismatch with the global readerConfig preset. We added a small bubble with fade-in, fade-out at the end of the "preset" trigger button in the readerMenu. When a mismatch occurs there is a lightly flashing round warning you, that you can save your local readerConfig settings to the global readerConfig registry, and then apply it to any other opened or not publication in Thorium.