Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance preset notification on configChanged #2686

Merged
merged 7 commits into from
Dec 3, 2024
Merged

Conversation

panaC
Copy link
Member

@panaC panaC commented Dec 2, 2024

Each new imported publication inherit from the default global readerConfig settings, (they're a kind of fork of the readerConfig). Each publication become independent, the user setting up the local readerConfig attached to the publication and can apply this readerConfig settings to a global registry called defaultReaderConfig. It's a global preset across the entire publication. When an user want to apply this global configuration to his current publication, he need to call back from the reader navigation preset menu. This is the new Thorium 3.1 behavior, there are an independent global readerConfig preset.

Now, I make the observation that the preset menu section is not very clear at all. It's difficult to call back and apply to the global readerConfig preset registry. We can't know when a divergence appears between the current local readerConfig publication and the global readerConfig preset. So that we propose Arthur and I is a discrete notification when there is a mismatch with the global readerConfig preset. We added a small bubble with fade-in, fade-out at the end of the "preset" trigger button in the readerMenu. When a mismatch occurs there is a lightly flashing round warning you, that you can save your local readerConfig settings to the global readerConfig registry, and then apply it to any other opened or not publication in Thorium.

@panaC panaC marked this pull request as ready for review December 3, 2024 10:20
@panaC panaC merged commit 3fe80a2 into develop Dec 3, 2024
7 checks passed
@panaC panaC deleted the dev/reader-preset branch December 3, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants