Move non-english language packs to AMOS

[abias]

Hi,

you are shipping non-english language packs with this plugin.

While this is technically correct, I would like to ask you to rethink this approach.

Moodle has a powerful tool called AMOS which can be found on https://lang.moodle.org/. The documentation is on https://docs.moodle.org/dev/AMOS_manual.
Within AMOS, the Moodle core as well as publish Moodle plugins are translated. This has two immediate benefits:

• The whole Moodle community can contribute to the translation of your plugin, you don't have to do everything yourself
• The community can add translations for languages which you don't want or are not able to manage within the plugin codebase.

As soon as this plugin is approved in the Moodle plugin repo, I would like to propose that you:

• Add the non-english translations of this plugin to AMOS
• Afterwards, remove the non-english language packs from the codebase and publish a new version into the plugin repo.

Cheers,
Alex

[abias]

You might have already noticed that the branding feature which has been added in b1ffc62 does not work for the german language in atto_edusharing - see screenshot:

This is because atto_edusharing has already been translated in AMOS by the community:

Language strings which are translated in AMOS overrule language strings which are shipped with the plugin. In this case, this means that the german language (including the branding parameters) which are shipped with the plugin are simply ignored.

You will only be able to solve this issue by managing the german language in AMOS directly. Unfortunately, before you can do this, you will have to solve edu-sharing/moodle-mod_edusharing#4 as well... :-/