Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEPR]: eox-theming #67

Open
MaferMazu opened this issue Oct 21, 2024 · 1 comment
Open

[DEPR]: eox-theming #67

MaferMazu opened this issue Oct 21, 2024 · 1 comment

Comments

@MaferMazu
Copy link
Contributor

Proposal Date

21 Oct 2024

Target Ticket Acceptance Date

TBD

Earliest Open edX Named Release Without This Functionality

Teak - 2025-04 or TBD

Rationale

Comes from https://github.com/eduNEXT/ednx-saas-themes/issues/230

I think this should we weighted alongside a deprecation for eox-theming.

From what I understand eox-theming provides two main features: The multi-level template inheritance and the extra_scripts context processor. If we are only using the css-runtime children then I don't think the former is too valuable. About the latter, I don't know how is its current state, but I think is not being used by the stratus clients, and needs a replacement in an MFE world.

If we are not really using the features on the plugin then it makes sense to drop support for future releases and make few adjustments to have less code to maintain.

Ref: https://github.com/eduNEXT/ednx-saas-themes/issues/230#issuecomment-2387144061

Removal

Include a description with links to what exactly is being removed.

Replacement

Include a description with links to what this is being replaced by.

Deprecation

If you plan to mark the code for deprecation, explain how.

Migration

If automated migration will be needed, explain your migration plan.

Additional Info

Comes from https://github.com/eduNEXT/ednx-saas-themes/issues/230

Task List

A list of tasks needed to deprecate or remove this feature and complete the DEPR.

@MaferMazu
Copy link
Contributor Author

This is a proposal. We need to figure out the implications and changes that need to be done before approving this. But I created it to no lose track of the proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant