From 6a98a8a1fa36ad35750baf51e00cca23fe9254a2 Mon Sep 17 00:00:00 2001 From: eduardklap Date: Fri, 23 Aug 2024 15:13:18 +0200 Subject: [PATCH] reduce estim_diff example runtime --- .Rbuildignore | 1 + R/estim_diff.R | 2 +- cran-comments.md | 32 +++++++++++--------------------- man/estim_diff.Rd | 2 +- 4 files changed, 14 insertions(+), 23 deletions(-) diff --git a/.Rbuildignore b/.Rbuildignore index 98b0728..0717dd0 100644 --- a/.Rbuildignore +++ b/.Rbuildignore @@ -11,3 +11,4 @@ ^Meta$ ^CITATION\.cff$ ^cran-comments\.md$ +^CRAN-SUBMISSION$ diff --git a/R/estim_diff.R b/R/estim_diff.R index 0ff8fb8..d85e718 100644 --- a/R/estim_diff.R +++ b/R/estim_diff.R @@ -38,7 +38,7 @@ #' @examples #' data_feedback <- feedback #' estim_diff(data_feedback, -#' c("mfg_learning", "mfg_application"), 20:271, +#' c("mfg_learning", "mfg_application"), 20:71, #' 10, "Feedback middle frontal gyrus") #' @export diff --git a/cran-comments.md b/cran-comments.md index f14eb53..3e2e73c 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -4,6 +4,12 @@ editor_options: wrap: 72 --- +## Resubmission + +This is a resubmission. In this version I have: + +- adapted the examples that exceeded the \> 5s runtime + ## R CMD check results 0 errors \| 0 warnings \| 1 note @@ -14,45 +20,29 @@ editor_options: #### Notes returned after running `devtools::check(remote = TRUE, manual = TRUE)`: -❯ checking CRAN incoming feasibility ... [5s/18s] NOTE Maintainer: +❯ checking CRAN incoming feasibility ... [4s/13s] NOTE Maintainer: ‘Eduard Klapwijk [et.klapwijk\@gmail.com](mailto:et.klapwijk@gmail.com){.email}’ New submission -❯ checking examples ... [14s/14s]NOTE - -Examples with CPU (user + system) or elapsed time \> 5s - -user system elapsed - -estim_diff 10.222 0.424 10.657 - ❯ checking HTML version of manual ... NOTE Found the following HTML validation problems: `estim_corr.html:4:1 (estim_corr.Rd:5): Warning: inserting "type" attribute estim_corr.html:12:1 (estim_corr.Rd:5): Warning: