Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new Sokol logging mechanism #23

Open
edubart opened this issue Sep 30, 2023 · 2 comments
Open

Use new Sokol logging mechanism #23

edubart opened this issue Sep 30, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@edubart
Copy link
Owner

edubart commented Sep 30, 2023

Sokol has a new style for logging stuff, would be nice if Sokol GP follows it.

@edubart edubart added the enhancement New feature or request label Sep 30, 2023
@kkukshtel
Copy link

Does it currently route to the bound logger in the sg_desc? I'm binding the logging there to an external function so want to make sure I'm getting gp errors.

@edubart
Copy link
Owner Author

edubart commented Oct 1, 2023

Does it currently route to the bound logger in the sg_desc? I'm binding the logging there to an external function so want to make sure I'm getting gp errors.

No, currently it follows the following logic:

#ifndef SOKOL_LOG
    #ifdef SOKOL_DEBUG
        #include <stdio.h>
        #define SOKOL_LOG(s) { SOKOL_ASSERT(s); puts(s); }
    #else
        #define SOKOL_LOG(s)
    #endif
#endif

But you can define SOKOL_LOG to override this behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants