Meteor release validation #17
Comments
why is it required on azure 🤔? |
sakulstra
added a commit
to MobileheadHolding/meteor-google-cloud
that referenced
this issue
Mar 19, 2020
The current version check doesn't work with two digit minor/major release numbers breaking at 1.10.x As I didn't see a good reason to have this check in first place I dropped it. - closes edvisor-io#17
|
@sakulstra Meteor <1.4 was using Node 0.10.x which doesn't support VC++15 for node-gyp (the only version Azure App Service would support) and ended up precipitating the Meteor Azure project: christopheranderson/azure-demeteorizer#23 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey @raphaelarias
Just a heads up that you won't be able to deploy Meteor 1.10+ at the moment due to a very naive attempt at release validation (carried over from meteor-azure) that cannot differentiate between minor versions 10 and 1 🤦♂
I've fixed this by using proper semver coercion (see fractal-code/meteor-azure@03df135) but you may want to switch off the validation entirely if this isn't a requirement for Google Cloud
See below, the offending code:
https://github.com/EducationLink/meteor-google-cloud/blob/cb72dca6ab970ddf841f7c223ac665c6ad44fbf6/src/lib/validation.js#L38-L47
The text was updated successfully, but these errors were encountered: