Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After the last changes the Relay button lights no longer work #28

Closed
TeDeVPrime opened this issue Aug 3, 2024 · 6 comments · Fixed by #32, #34, #36 or #55
Closed

After the last changes the Relay button lights no longer work #28

TeDeVPrime opened this issue Aug 3, 2024 · 6 comments · Fixed by #32, #34, #36 or #55
Labels
bug Something isn't working

Comments

@TeDeVPrime
Copy link

@edwardtfn
I did the new update and the swipe seems to be working fine now
but i lost the lights when the relay is on.
am i doing something wrong? here is a screenshot

image

@edwardtfn
Copy link
Owner

I will take a look

@iceteaSA
Copy link

Any progress on this? Checking the code, there is a return that short-circuits the action.

@edwardtfn edwardtfn added the bug Something isn't working label Dec 20, 2024
edwardtfn added a commit that referenced this issue Dec 20, 2024
That was crashing that method right after boot.

- Solves #28
@edwardtfn edwardtfn linked a pull request Dec 20, 2024 that will close this issue
edwardtfn added a commit that referenced this issue Dec 20, 2024
Solves #28
I believe this also solves #21
This was linked to pull requests Dec 20, 2024
@edwardtfn
Copy link
Owner

Could you please update to the latest version and try again?
Please let me know the results.

@TeDeVPrime
Copy link
Author

@edwardtfn nope. it doesn't work. If i set my middle relay to Light as shown in the picture above... it will not turn on the light.

it is like the switch is attached to the relay mode and not the state of the button.
if i turn the Relay 2 Mode back to a Relay.... then the lights on the switch come on

@edwardtfn edwardtfn reopened this Dec 21, 2024
@iceteaSA
Copy link

iceteaSA commented Dec 21, 2024

@edwardtfn On my side (US-Variant 2-4 Gang) it is mostly working correctly. Except only the right side LEDs are mapped correctly, the left side seems to be off, with the top LEDs coming on for the top gangs, and the middle ones for the bottom gangs. Another issue is that state is not restored properly on boot. The status lights will still burn, and HA reports the lights to be on, but the relays are not triggered, meaning the actual lights are still off. Also, the LEDs reset back to white on boot if you power cycle it.

@edwardtfn edwardtfn added the work in progress Someone is working on a solution for this label Dec 22, 2024
edwardtfn added a commit that referenced this issue Dec 22, 2024
@edwardtfn edwardtfn linked a pull request Dec 22, 2024 that will close this issue
@edwardtfn
Copy link
Owner

This should be fixed now. Could you please update your system and try it again?

@edwardtfn edwardtfn removed the work in progress Someone is working on a solution for this label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants