From b85d44548758dcb132b4007891c26aa7fa925569 Mon Sep 17 00:00:00 2001 From: Bilal Qamar <59555732+BilalQamar95@users.noreply.github.com> Date: Tue, 1 Oct 2024 17:06:58 +0500 Subject: [PATCH 1/2] test: Add Node 20 to CI matrix --- .github/workflows/ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a38698b77..67a65ee21 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -13,7 +13,8 @@ jobs: python-version: ["3.8", "3.12"] os: [ubuntu-20.04] toxenv: [django42] - node: [18] + node: [18, 20] + continue-on-error: ${{ matrix.node == 20 }} env: DATA_API_VERSION: "latest" steps: From 5d497bf357f1e7c381fbb46186857c23bef963c0 Mon Sep 17 00:00:00 2001 From: Bilal Qamar <59555732+BilalQamar95@users.noreply.github.com> Date: Wed, 2 Oct 2024 15:07:39 +0500 Subject: [PATCH 2/2] refactor: updated node version for testing-js --- .github/scripts/testing-js.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/scripts/testing-js.sh b/.github/scripts/testing-js.sh index d49f63528..6ad455863 100755 --- a/.github/scripts/testing-js.sh +++ b/.github/scripts/testing-js.sh @@ -1,8 +1,8 @@ -if [[ $NODE == 18 ]] +if [[ $NODE == 20 ]] then - export NODE_VERSION=18.20.2 + export NODE_VERSION=20.15.1 else - export NODE_VERSION=16.14.0 + export NODE_VERSION=18.20.2 fi docker exec -t insights_testing bash -c "