-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Django version of eduNEXT Flask codejail service #894
Comments
timmc-edx
added a commit
to edx/public-dockerfiles
that referenced
this issue
Jan 23, 2025
Lots of differences from cookiecutter django-ida default: - Remove MySQL system packages - Use latest Ubuntu LTS - Shorten the base folder from `codejail-service` to `codejail` - Use port 8080; we'll remap it in compose anyhow - Use ADD on a git repo rather than RUN/curl/tar, which runs afoul of Docker caching when a branch is used. - Allow selecting a commit version - Pass `DJANGO_SETTINGS_MODULE` from outside as env var to reduce differences between dev and prod targets and add flexibility. - Install in /app and create virtualenv in /venv; no need to hew to the same pattern we used in the configuration repo. - Remove apt cache in same RUN command so as not to create a fat layer - Use heredoc syntax for multi-command RUN - No log files, just log to stdout See edx/edx-arch-experiments#894
timmc-edx
added a commit
to edx/public-dockerfiles
that referenced
this issue
Jan 23, 2025
This is just a skeleton image and doesn't have any directories or packages that are specific to codejail yet. Lots of differences from cookiecutter django-ida default: - Remove MySQL system packages - Use latest Ubuntu LTS - Shorten the base folder from `codejail-service` to `codejail` - Use port 8080; we'll remap it in compose anyhow - Use ADD on a git repo rather than RUN/curl/tar, which runs afoul of Docker caching when a branch is used. - Allow selecting a commit version - Pass `DJANGO_SETTINGS_MODULE` from outside as env var to reduce differences between dev and prod targets and add flexibility. - Install in /app and create virtualenv in /venv; no need to hew to the same pattern we used in the configuration repo. - Remove apt cache in same RUN command so as not to create a fat layer - Use heredoc syntax for multi-command RUN - No log files, just log to stdout See edx/edx-arch-experiments#894
timmc-edx
added a commit
to edx/devstack
that referenced
this issue
Jan 23, 2025
The image specified here is not yet available, but should be the right name for after <edx/public-dockerfiles#85> merges. I've tested with a local tag. This is part of edx/edx-arch-experiments#894
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Acceptance Criteria:
PRs:
Implementation notes:
The text was updated successfully, but these errors were encountered: