Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add missing course properties in IAP restore & unfulfilled events #82

Merged
merged 5 commits into from
Jan 27, 2025
Merged

chore: add missing course properties in IAP restore & unfulfilled events #82

merged 5 commits into from
Jan 27, 2025

Conversation

farhan-arshad-dev
Copy link
Member

Description

  • Add Properties in IAP Restore and Unfulfilled Events.

Jira: LEARNER-10309

@farhan-arshad-dev farhan-arshad-dev changed the title 2 u/farhan ar/learner 10309 chore: add missing course properties in IAP restore & unfulfilled events Jan 13, 2025
HamzaIsrar12
HamzaIsrar12 requested changes Jan 17, 2025
View reviewed changes
Copy link

@HamzaIsrar12 HamzaIsrar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have four additional improvements to address that I forgot to mention in the underline ticket:

  • Ensure the unfulfilled flow functions correctly, even when there's only a single course.
  • Trigger CourseUpgradeSuccess regardless of the user's choice on the Unfulfilled Refresh-or-Continue dialog.
  • Include these properties in the CourseUpgradeSuccess event during the unfulfilled flow.
  • Since the flow sends only one event for all unfulfilled courses, it's better to limit it to one process per session or click to ensure the correct number of CourseUpgradeSuccess events are sent.

Thank you!

core/src/main/java/org/openedx/core/domain/interactor/IAPInteractor.kt Outdated Show resolved Hide resolved
core/src/main/java/org/openedx/core/domain/interactor/IAPInteractor.kt Show resolved Hide resolved
core/src/main/java/org/openedx/core/system/notifier/app/AppNotifier.kt Show resolved Hide resolved
@farhan-arshad-dev farhan-arshad-dev force-pushed the 2U/farhan_ar/LEARNER-10309 branch from aef2823 to 3e7c595 Compare January 20, 2025 14:26
@farhan-arshad-dev
Copy link
Member Author

Ensure the unfulfilled flow functions correctly, even when there's only a single course.

done.

Trigger CourseUpgradeSuccess regardless of the user's choice on the Unfulfilled Refresh-or-Continue dialog.

done.

Include these properties in the CourseUpgradeSuccess event during the unfulfilled flow.

done.

Since the flow sends only one event for all unfulfilled courses, it's better to limit it to one process per session or click to ensure the correct number of CourseUpgradeSuccess events are sent.

done.

HamzaIsrar12
HamzaIsrar12 requested changes Jan 20, 2025
View reviewed changes
Copy link

@HamzaIsrar12 HamzaIsrar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The Refresh Now sends another Course Upgrade Success event
  • No properties available in Course Upgrade Success after Restore Purchase

core/src/main/java/org/openedx/core/domain/interactor/IAPInteractor.kt Outdated Show resolved Hide resolved
core/src/main/java/org/openedx/core/domain/interactor/IAPInteractor.kt Outdated Show resolved Hide resolved
course/src/main/java/org/openedx/course/presentation/container/CourseContainerViewModel.kt Show resolved Hide resolved
core/src/main/java/org/openedx/core/presentation/iap/IAPViewModel.kt Outdated Show resolved Hide resolved
@farhan-arshad-dev
Copy link
Member Author

The Refresh Now sends another Course Upgrade Success event

fixed.

No properties available in Course Upgrade Success after Restore Purchase

added.

k1rill
k1rill approved these changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@k1rill k1rill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

HamzaIsrar12
HamzaIsrar12 approved these changes Jan 27, 2025
View reviewed changes
Copy link

@HamzaIsrar12 HamzaIsrar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the following flows, and the Payment:Course Upgrade Success event is firing as expected with all the necessary properties needed in Analytics:

Tested Flows:

  • Restore Mode
  • Silent Mode
  • Enrollments Screen
  • Dashboard Screen
  • Expired Screen

@farhan-arshad-dev farhan-arshad-dev merged commit 76ff3f0 into 2U/develop Jan 27, 2025
3 checks passed
@farhan-arshad-dev farhan-arshad-dev deleted the 2U/farhan_ar/LEARNER-10309 branch January 27, 2025 13:02
farhan-arshad-dev added a commit that referenced this pull request Jan 29, 2025
@farhan-arshad-dev
chore: add missing course properties in IAP restore & unfulfilled eve…
aef1a27 
…nts (#82)

* chore: add missing course properties in IAP unfulfilled event

* chore: add missing course properties in IAP restore purchases event

fixes: LEARNER-10309
@farhan-arshad-dev farhan-arshad-dev mentioned this pull request Jan 30, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HamzaIsrar12 HamzaIsrar12 HamzaIsrar12 approved these changes

@k1rill k1rill k1rill approved these changes

@omerhabib26 omerhabib26 Awaiting requested review from omerhabib26

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@farhan-arshad-dev @k1rill @HamzaIsrar12