Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not create a proposal.pay entry when the amount in 0 #185

Open
jeisses opened this issue Jan 15, 2023 · 0 comments
Open

Do not create a proposal.pay entry when the amount in 0 #185

jeisses opened this issue Jan 15, 2023 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@jeisses
Copy link
Member

jeisses commented Jan 15, 2023

If a proposal does not have a reward, it should not create a pay entry in the blockchain.
This is wasted RAM and also introduced a bug that the proposal can note be executed because the amount is not positive.
This bug has been fixed on the smart contract side; however for clarity and efficiency we should still not add 0-pay reward entries

Steps

  • On proposal create and proposal edit, check if the reward is 0. In this case, submit an empty array in the proposal.pay field.
@jeisses jeisses added bug Something isn't working good first issue Good for newcomers labels Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant