Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup shell magic in 00-setup-introduction #5

Open
figaw opened this issue Aug 29, 2022 · 0 comments
Open

Cleanup shell magic in 00-setup-introduction #5

figaw opened this issue Aug 29, 2022 · 0 comments

Comments

@figaw
Copy link
Contributor

figaw commented Aug 29, 2022

The task "Task: Inject sidecar for the age service" in 00-setup-introduction doesn't really add anything istio-wise to the exercise, it's more of an inline-text-editing trick.

If you know that you can cat a manifest to kubectl apply -f - and you know that grep -v can strip lines from the input, it should be "obvious" that.. you can strip the annotation.

If you don't know these things, an istio course might not be the right place to add it?

The continuation of the exercise also isn't using that we re-add the proxy.

Please discuss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant