Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call reboot-instances instead of stop/start in fix-instance-id.sh #13

Open
cuppett opened this issue Nov 25, 2022 · 2 comments
Open

Call reboot-instances instead of stop/start in fix-instance-id.sh #13

cuppett opened this issue Nov 25, 2022 · 2 comments

Comments

@cuppett
Copy link
Collaborator

cuppett commented Nov 25, 2022

In fix-instance-id.sh, we could call reboot-instances EC2 command instead of stop/start. Stopping while the host is under a persistent spot request can cause a race condition with AWS trying to restart it for you.

Also, if the host is set to "terminate on stop" outside of our script's happy path, then that stop command will inadvertently terminate it.
@eformat
Copy link
Owner

eformat commented Jun 11, 2023

this is more robust now with recent changes.

@cuppett
Copy link
Collaborator Author

cuppett commented Jun 26, 2023

(Mobile) Does it still have a stop/start moment in the script is that no longer in there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cuppett @eformat