Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not fail pull requests from forks on trigger-detector-benchmarks #63

Open
wdconinc opened this issue Aug 17, 2022 · 0 comments · May be fixed by #318
Open

Do not fail pull requests from forks on trigger-detector-benchmarks #63

wdconinc opened this issue Aug 17, 2022 · 0 comments · May be fixed by #318
Assignees
Labels
bug Something isn't working topic: infrastructure Regarding build system, CI, CD

Comments

@wdconinc
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Pull requests from a fork do not have access to the secrets necessary to trigger eicweb benchmarks in the trigger-detector-benchmarks job, and consequently that job fails, e.g. #61. There is no way to 'unfail' this job without going through the API.

Describe the solution you'd like
We should succeed the trigger-detector-benchmarks job, but use it to set the eicweb/detector-benchmarks status to pending. This way, the status will remain pending until someone starts the pipeline by hand, at which point the pipeline will succeed and no remaining failed jobs remain

Describe alternatives you've considered
No other alternatives considered...

@wdconinc wdconinc self-assigned this Aug 17, 2022
@veprbl veprbl added the bug Something isn't working label Aug 18, 2022
@veprbl veprbl added the topic: infrastructure Regarding build system, CI, CD label Oct 1, 2022
@wdconinc wdconinc linked a pull request Nov 23, 2022 that will close this issue
7 tasks
@wdconinc wdconinc linked a pull request Nov 23, 2022 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working topic: infrastructure Regarding build system, CI, CD
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants