Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved electron beam pipe modelling #691

Closed
wants to merge 46 commits into from
Closed
Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
696eb3b
Private changes as on March 19, 2024 - improved beam pipe, slightly m…
Mar 21, 2024
61ab792
Improved Central and Far-Backward beam pipes. Enlarged R_min for forw…
Mar 22, 2024
cccf439
Fixed a typo
Mar 22, 2024
aa8f64e
Change Lumi Exit window to Calorimeter
Mar 25, 2024
f3c86ec
Make Lumi Exit Window sensetive
Mar 25, 2024
44c6d17
temp modify .gitignore
Mar 29, 2024
d2ac0b1
Changes before merging with the main branch
Mar 29, 2024
b18c8d6
Forgotten changes
Mar 29, 2024
d035b34
Described the corrected central beam pipe through XML parameters
Mar 29, 2024
005e8b1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 29, 2024
490c56c
revert development byproduct changes
veprbl Apr 1, 2024
9b7415a
Fix overlaps between DRICH and BeamPipe_assembly
Apr 1, 2024
f9adaf8
Merge branch 'eic_sr_background_study' of github.com:eic/epic into ei…
Apr 1, 2024
82db90b
Get the end of the central beam pipe for hadrons from the XML file in…
Apr 1, 2024
aed857a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 1, 2024
8427111
Define backward electron beam pipe parameters as a list of constants …
Apr 1, 2024
2d99a6d
Merge branch 'eic_sr_background_study' of github.com:eic/epic into ei…
Apr 1, 2024
84a3712
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 1, 2024
857c7d8
Avoid duplication the API in src/IP6BeamPipe.cpp. Added global consta…
Apr 1, 2024
63c4bfc
Merge branch 'eic_sr_background_study' of github.com:eic/epic into ei…
Apr 1, 2024
e4ee1c0
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 1, 2024
2bb7f3c
Avoid duplication of the same beam pipe parameters (e.g., Z or OD)
Apr 1, 2024
8262e8f
Avoid duplication of the same beam pipe parameters (e.g., Z or OD)
Apr 1, 2024
4fa5b0a
Avoid duplication the API in src/IP6BeamPipe.cpp
Apr 2, 2024
5ce7f64
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 2, 2024
664ecf4
minor typo fixing
Apr 2, 2024
938fe24
Merge branch 'eic_sr_background_study' of github.com:eic/epic into ei…
Apr 2, 2024
ec69b1b
Modified far-backward beam pipe materials
Apr 5, 2024
2b88eac
Added coating and changed materials for backward magnets (Q1eR, Q2eR,…
Apr 5, 2024
cb400ed
Corrected central beam pipe aperture
Apr 5, 2024
48fd46d
Added coating to the central beam pipe
Apr 6, 2024
5b14365
Fixed beam pipe volume subtraction logic
Apr 7, 2024
f5c5f26
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 8, 2024
bcadf00
Added SR mask-5 to avoid SR reflectio nfrom the flat beam pipe tip at…
Apr 12, 2024
6dd3d6c
Merge and pull
Apr 12, 2024
fb480cc
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 12, 2024
be5f28a
fixed strange git symbols
Apr 13, 2024
456a73d
Updated FWD TOF tracker according to the latest detector numbers
Apr 16, 2024
28b2477
Updated FWD MPGD tracker according to the latest detector numbers
Apr 16, 2024
d6eca3f
Added an upstream lepton-hadron joint between the backward and ip bea…
Apr 21, 2024
cb5ce6a
Merge branch 'eic_sr_background_study' of github.com:eic/epic into ei…
Apr 21, 2024
2e5d19c
fix: clang-format
wdconinc May 7, 2024
4dd2c82
Merge remote-tracking branch 'origin/main' into eic_sr_background_study
wdconinc May 7, 2024
e580c42
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 7, 2024
0cf1cb3
Added comments to the IP6 beam pipe src code for testing the old pull…
nat93 Sep 11, 2024
ed325d4
Merge branch 'main' of github.com:eic/epic into eic_sr_background_study
Sep 11, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 39 additions & 16 deletions compact/central_beampipe.xml
Original file line number Diff line number Diff line change
Expand Up @@ -31,45 +31,68 @@
subtract_matter="false">
<outgoing_lepton thickness="2.0*mm">
<zplane z="BeampipeUpstreamStraightLength" OD="BeampipeOD"/>
<zplane z="2690.95 * mm" OD="85.616 * mm"/>
<zplane z="4560.17 * mm" OD="99.20 * mm"/>
<zplane z="5000.00 * mm" OD="97.715 * mm"/>
</outgoing_lepton>
<incoming_hadron thickness="1.65*mm"
crossing_angle="CrossingAngle">
<!-- avoid overlap with IP beampipe by starting slightly displaced -->
<zplane z="BeampipeUpstreamStraightLength + 0.5 * max(BeampipeOD, 24.714 * mm) * tan(abs(CrossingAngle))" OD="24.714 * mm"/>
<zplane z="2690.95 * mm" OD="24.714 * mm"/>
<zplane z="2710.75 * mm" OD="31.75 * mm"/>
<zplane z="2690.95 * mm" OD="31.75 * mm"/>
<zplane z="2890.35 * mm" OD="31.75 * mm"/>
<zplane z="2940.35 * mm" OD="44.45 * mm"/>
<zplane z="4490.35 * mm" OD="44.45 * mm"/>
<zplane z="5000.00 * mm" OD="44.45 * mm"/>
</incoming_hadron>
</upstream>

<comment> For downstream beampipe (where on is inside the vacuum of the other), we subtract the matter from the vacuum, and subtract an additional pipe to create the angled cutout</comment>
<downstream reflect="false"
place_vacuum="true"
subtract_vacuum="false"
subtract_vacuum="true"
subtract_matter="true">
<incoming_lepton thickness="1.0*mm">
<zplane z="BeampipeDownstreamStraightLength" OD="BeampipeOD"/>
<zplane z="4484.25 * mm" OD="BeampipeOD"/>
<zplane_vac z="670.00 * mm" OD="60.00 * mm"/>
<zplane_vac z="755.00 * mm" OD="60.00 * mm"/>
<zplane_vac z="755.00 * mm" OD="62.00 * mm"/>
<zplane_vac z="4300.00 * mm" OD="62.00 * mm"/>
<zplane_vac z="4450.00 * mm" OD="44.00 * mm"/>
<zplane_vac z="4460.00 * mm" OD="44.00 * mm"/>
<zplane_vac z="4660.00 * mm" OD="54.00 * mm"/>
<zplane_vac z="5100.00 * mm" OD="54.00 * mm"/>

<zplane_mat z="670.00 * mm" OD="(62.00 + 1.0 * 2) * mm"/>
<zplane_mat z="(670.00 + 1.0) * mm" OD="(62.00 + 1.0 * 2) * mm"/>
<zplane_mat z="(670.00 + 1.0) * mm" OD="(60.00 + 1.0 * 2) * mm"/>
<zplane_mat z="(755.00 - 1.0) * mm" OD="(60.00 + 1.0 * 2) * mm"/>
<zplane_mat z="(755.00 - 1.0) * mm" OD="(62.00 + 1.0 * 2) * mm"/>
<zplane_mat z="4300.00 * mm" OD="(62.00 + 1.0 * 2) * mm"/>
<zplane_mat z="4450.00 * mm" OD="(44.00 + 1.0 * 2) * mm"/>
<zplane_mat z="4460.00 * mm" OD="(44.00 + 1.0 * 2) * mm"/>
<zplane_mat z="4660.00 * mm" OD="(54.00 + 1.0 * 2) * mm"/>
<zplane_mat z="5100.00 * mm" OD="(54.00 + 1.0 * 2) * mm"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like the duplication of all z and many of the OD values here. Can we approach this conceptually different so it doesn't require this level of duplication?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now also adds another methodology to define beampipes: we can still use <zplane> but now we have <zplane_mat> and <zplane_vac>. We may want to have one way, which sensibly defaults back to the previous behavior.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Thanks. I will think about this.

</incoming_lepton>
<outgoing_hadron thickness="4.0*mm"
axis_intersection="670.0 * mm"
horizontal_offset="15.0 * mm"
cone_z_end="5000.0 * mm"
cone_z_start="870.0 * mm"
extension_r="27.5 * mm"
extension_z="600.0 * mm"
extension_thickness="1.65 * mm"
crossing_angle="CrossingAngle">
<!-- avoid overlap with IP beampipe by starting slightly displaced -->
<zplane z="BeampipeDownstreamStraightLength + 0.5 * BeampipeOD * tan(abs(CrossingAngle))" OD="BeampipeOD"/>
<zplane z="1750.00 * mm" OD=" 92.06 * mm"/>
<zplane z="4455.80 * mm" OD="257.92 * mm"/>
<!-- removed due to vacuum overlap with far forward electron beampipe -->
<!--zplane z="5000.00 * mm" OD="340.60 * mm"/-->
<zplane_vac z="670.00 * mm" OD="62.00 * mm"/>
<zplane_vac z="5100.00 * mm" OD="(62.00 + 2 * (5100.00 - 670.00) * tan(abs(CrossingAngle))) * mm"/>

<zplane_mat z="670.00 * mm" OD="(62.00 + 4.0 * 2) * mm"/>
<zplane_mat z="5100.00 * mm" OD="(62.00 + 2 * (5100.00 - 670.00) * tan(abs(CrossingAngle)) + 4.0 * 2) * mm"/>
</outgoing_hadron>
<additional_subtraction thickness="4.0*mm"
crossing_angle="CrossingAngle">
<!-- these are somewhat arbitrary to get the right hole shape -->
<zplane z="BeampipeDownstreamStraightLength" OD="32. * mm"/>
<zplane z="4484.25 * mm" OD="120. * mm"/>
<zplane_vac z="870.00 * mm" OD="(36.61 - 4.0 * 2) * mm"/>
<zplane_vac z="4484.25 * mm" OD="(120.00 - 4.0 * 2) * mm"/>

<zplane_mat z="670.00 * mm" OD="(32.00) * mm"/>
<zplane_mat z="4484.25 * mm" OD="(120.00) * mm"/>
</additional_subtraction>
</downstream>
</detector>
Expand Down
29 changes: 13 additions & 16 deletions compact/far_backward/definitions.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,30 +5,27 @@

<comment> Connection to central beam pipe </comment>

<constant name="Center_Beampipe_End" value="-4560.17*mm"/>
<constant name="Center_Beampipe_Rad" value="47.60*mm"/>
<constant name="Center_Beampipe_End" value="-5000.0 * mm"/>
<constant name="Center_Beampipe_Rad" value="97.715/2 * mm"/>

<constant name="Hadron_Beampipe_End" value="-4490.35*mm"/>
<constant name="Hadron_Beampipe_Rad" value="50*mm"/>
<constant name="Hadron_Beampipe_Thickness" value="1.64*mm"/>

<comment> Electron magnet dimensions and positions </comment>

<constant name="Q1eR_InnerRadius" value="67.5*mm"/>
<constant name="Q1eR_Length" value="1.78*m"/>
<constant name="Q1eR_CenterPosition" value="-6.2*m"/>
<constant name="Q1eR_InnerRadius" value="57.70 * mm"/>
<constant name="Q1eR_Length" value="1.80 * m"/>
<constant name="Q1eR_CenterPosition" value="(-7.1+1.8/2) * m"/>

<constant name="Q2eR_InnerRadius" value="78.0*mm"/>
<constant name="Q2eR_Length" value="1.4*m"/>
<constant name="Q2eR_CenterPosition" value="-8.3*m"/>
<constant name="Q2eR_InnerRadius" value="66.30 * mm"/>
<constant name="Q2eR_Length" value="1.4 * m"/>
<constant name="Q2eR_CenterPosition" value="(-9.0 + 1.4/2) * m"/>

<constant name="B2AeR_InnerRadius" value="90.0*mm"/>
<constant name="B2AeR_Length" value="1.78*m"/>
<constant name="B2AeR_CenterPosition" value="-10.5*m"/>

<constant name="B2BeR_InnerRadius" value="111.0*mm"/>
<constant name="B2BeR_Length" value="3.18*m"/>
<constant name="B2BeR_CenterPosition" value="-13.275*m"/>
<constant name="B2BeR_InnerRadius" value="100.0 * mm"/>
<constant name="B2BeR_Length" value="5.500075391030 * m"/>
<constant name="B2BeR_CenterPosition" value="-15.000075390000 * m + B2BeR_Length/2"/>
Comment on lines +49 to +50
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the microns matter here?

Suggested change
<constant name="B2BeR_Length" value="5.500075391030 * m"/>
<constant name="B2BeR_CenterPosition" value="-15.000075390000 * m + B2BeR_Length/2"/>
<constant name="B2BeR_Length" value="5.5 * m"/>
<constant name="B2BeR_CenterPosition" value="-15.0 * m + B2BeR_Length/2"/>

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, I simply follow the lattice file v6.2.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are following a specific lattice version, we should mention this in one of the comments somewhere, with a reference for where one can find this lattice version (even if not publicly accessible).

<constant name="B2BeR_Edge" value="5.0 * mm"/>

<constant name="Q3eR_InnerRadius" value="0.05*m"/>
<constant name="Q3eR_Length" value="0.6*m"/>
Expand Down Expand Up @@ -174,7 +171,7 @@
<constant name="Vacuum_BB_MaxX" value="0.5*m"/>
<constant name="Vacuum_BB_MinY" value="-1.5*m"/>
<constant name="Vacuum_BB_MaxY" value="1.5*m"/>
<constant name="Vacuum_BB_MinZ" value="B2BeR_CenterPosition-B2BeR_Length/2"/>
<constant name="Vacuum_BB_MinZ" value="B2BeR_CenterPosition-B2BeR_Length/2 - B2BeR_Edge"/>
<constant name="Vacuum_BB_MaxZ" value="Q3eR_EndZ"/>

<constant name="Beam_Theta" value="Q3eR_Theta"/>
Expand Down
10 changes: 9 additions & 1 deletion compact/far_backward/lumi/exit_window.xml
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,19 @@
name="LumiWindow"
type="LumiWindow"
material="Aluminum"
vis="AnlLightGray">
vis="AnlLightGray"
readout="LumiWindowCALHits">
<dimensions x="LumiWin_R" y="LumiWin_R" z="LumiWin_thickness/2" />
<position x="0" y="0" z="LumiWin_Z" />
<rotation x="0*rad" y="0*rad" z="0*rad" />
</detector>
</detectors>

<readouts>
<readout name="LumiWindowCALHits">
<segmentation type="NoSegmentation"/>
<id>system:8</id>
</readout>
</readouts>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is supposed to go into the official geometry. Why do we need this?

Copy link
Author

@nat93 nat93 Apr 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @veprbl ,
Thanks for your comment. The motivation for making the luminosity monitor exit window sensitive to radiation is that we have to study this element (a simple aluminum block) and check if it will survive under a high flux of synchrotron radiation photons. So far, the preliminary study showed that at 18 GeV, 0.227 A electron beam, the window will melt in 2 hours. So, we have to think about additional cooling. Therefore, I would suggest keeping this part of the code to collect deposited energy in that element.
What do you think?

</lccdd>
66 changes: 30 additions & 36 deletions compact/far_backward/magnets.xml
Original file line number Diff line number Diff line change
Expand Up @@ -13,33 +13,40 @@
type="BeamPipeChain"
wall_thickness="2*mm"
vis="BeamPipeVis">
<pipe id="0" name="Pipe_to_Q1eR"
xcenter="0" zcenter="(Center_Beampipe_End + Q1eR_CenterPosition+Q1eR_Length/2)/2"
length="Center_Beampipe_End - (Q1eR_CenterPosition+Q1eR_Length/2)" theta="0"
rout1="Center_Beampipe_Rad" rout2="Q1eR_InnerRadius">
<pipe id="0" name="Pipe_0"
xcenter="0" zcenter="-7342.0 * mm + (Center_Beampipe_End + 7342.0 * mm)/2"
length="Center_Beampipe_End + 7342.0 * mm" theta="0"
rout1="Center_Beampipe_Rad" rout2="(111.40/2 + 2) * mm">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should avoid changing parametrized values into hard-coded values that are then used in multiple places. (Applies file-wide.)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is true. However, I would suggest keeping the beam pipe geometry separated from the magnet geometry because they have different sources (i.e., the beam pipe model is from the vacuum and background groups, magnets -- lattice and magnet groups). Also, the inner radius of magnets should not always follow the beam pipe radius.
I can create beam pipe global variables in the central-beam pipe XML file to be used here. What do you think @wdconinc ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if we need them all as global variables in the central beam pipe; they can be local variables in the far_backward and far_forward sections, right?

</pipe>
<pipe id="1" name="Pipe_in_Q1eR"
xcenter="0" zcenter="Q1eR_CenterPosition"
length="Q1eR_Length" theta="0"
rout1="Q1eR_InnerRadius" rout2="Q1eR_InnerRadius">
<pipe id="1" name="Pipe_1"
xcenter="0" zcenter="-7405.0 * mm + (7405.00 - 7342.0)/2 * mm"
length="(7405.00 - 7342.0) * mm" theta="0"
rout1="(111.40/2 + 2) * mm" rout2="(128.60/2 + 2) * mm">
</pipe>
<pipe id="2" name="Pipe_Q1eR_to_Q2eR"/>
<pipe id="3" name="Pipe_in_Q2eR"
xcenter="0" zcenter="Q2eR_CenterPosition"
length="Q2eR_Length" theta="0"
rout1="Q2eR_InnerRadius" rout2="Q2eR_InnerRadius">
<pipe id="2" name="Pipe_2"
wdconinc marked this conversation as resolved.
Show resolved Hide resolved
xcenter="0" zcenter="-9288.0 * mm + (9288.0 - 7405.00)/2 * mm"
length="(9288.0 - 7405.00) * mm" theta="0"
rout1="(128.60/2 + 2) * mm" rout2="(128.60/2 + 2) * mm">
</pipe>
<pipe id="4" name="Pipe_Q2eR_to_B2AeR"/>
<pipe id="5" name="Pipe_in_B2AeR"
xcenter="0" zcenter="B2AeR_CenterPosition"
length="B2AeR_Length" theta="0"
rout1="B2AeR_InnerRadius" rout2="B2AeR_InnerRadius">
<pipe id="3" name="Pipe_3"
xcenter="0" zcenter="-9364.0 * mm + (9364.0 - 9288.0)/2 * mm"
length="(9364.0 - 9288.0) * mm" theta="0"
rout1="(128.60/2 + 2)* mm" rout2="(154.00/2 + 2) * mm">
</pipe>
<pipe id="6" name="Pipe_B2AeR_to_B2BeR"/>
<pipe id="7" name="Pipe_in_B2BeR"
xcenter="0" zcenter="B2BeR_CenterPosition"
length="B2BeR_Length" theta="0"
rout1="B2BeR_InnerRadius" rout2="B2BeR_InnerRadius">
<pipe id="4" name="Pipe_4"
xcenter="0" zcenter="-11364.0 * mm + (11364.0 - 9364.0)/2 * mm"
length="(11364.0 - 9364.0) * mm" theta="0"
rout1="(154.00/2 + 2) * mm" rout2="(154.00/2 + 2) * mm">
</pipe>
<pipe id="5" name="Pipe_5"
xcenter="0" zcenter="-11414.0 * mm + (11414.0 - 11364.0)/2 * mm"
length="(11414.0 - 11364.0) * mm" theta="0"
rout1="(154.00/2 + 2) * mm" rout2="(196.00/2 + 2) * mm">
</pipe>
<pipe id="6" name="Pipe_6"
xcenter="0" zcenter="(B2BeR_CenterPosition - B2BeR_Length/2 - B2BeR_Edge) + (abs(B2BeR_CenterPosition - B2BeR_Length/2 - B2BeR_Edge) - 11414.0 * mm)/2"
length="abs(B2BeR_CenterPosition - B2BeR_Length/2 - B2BeR_Edge) - 11414.0 * mm" theta="0"
rout1="(196.00/2 + 2) * mm" rout2="(196.00/2 + 2) * mm">
</pipe>
</detector>

Expand All @@ -59,13 +66,6 @@
<coil dx="2*cm" dy="1.5*cm" /><!--unchecked-->
</detector>

<detector name="Magnet_B2AeR" type="ip6_CylindricalDipoleMagnet" vis="FFMagnetVis">
<placement x="0" y="0" z="B2AeR_CenterPosition" theta="0*rad"/>
<dimensions x="B2AeR_InnerRadius*4" y="B2AeR_InnerRadius*4" z="B2AeR_Length" r="1.5*B2AeR_InnerRadius"/>
<apperture x="B2AeR_InnerRadius*2" y="B2AeR_InnerRadius*2" r="B2AeR_InnerRadius"/>
<coil dx="2*cm" dy="1.5*cm" /><!--unchecked-->
</detector>

<detector name="Magnet_B2BeR" type="ip6_CylindricalDipoleMagnet" vis="FFMagnetVis">
<placement x="0" y="0" z="B2BeR_CenterPosition" theta="0*rad"/>
<dimensions x="B2BeR_InnerRadius*4" y="B2BeR_InnerRadius*4" z="B2BeR_Length" r="1.5*B2BeR_InnerRadius"/>
Expand Down Expand Up @@ -110,12 +110,6 @@
<coefficient coefficient="Q3eR_Gradient"/>
</field>

<field name="Magnet_B2AeR_Field" type="MultipoleMagnet">
<shape type="Tube" rmax="B2AeR_InnerRadius" dz="B2AeR_Length/2"/>
<position x="0" y="0" z="B2AeR_CenterPosition"/>
<coefficient coefficient="B2AeR_B"/>
</field>

<field name="Magnet_B2BeR_Field" type="MultipoleMagnet">
<shape type="Tube" rmax="B2BeR_InnerRadius" dz="B2BeR_Length/2"/>
<position x="0" y="0" z="B2BeR_CenterPosition"/>
Expand Down
4 changes: 2 additions & 2 deletions compact/far_forward/electron_beamline.xml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
<constant name="Beampipe_cen_pos_Thickness" value="1.0*mm"/>

<!-- end of central section -->
<constant name="Beampipe_cen_pos_EndZ" value="4484.25*mm"/>
<constant name="Beampipe_cen_pos_r1" value="BeampipeOD/2."/>
<constant name="Beampipe_cen_pos_EndZ" value="5100.00 * mm"/>
<constant name="Beampipe_cen_pos_r1" value="(54.00/2.0 + 1.0) * mm"/>

<!-- Q0eF quadrupole magnet -->
<constant name="Q0EF_StartZ" value="7000.*mm"/>
Expand Down
6 changes: 3 additions & 3 deletions compact/tracking/definitions_craterlake.xml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
<comment> Forward TOF region </comment>
<constant name="ForwardTOFRegion_zmin" value="174.0*cm" />
<constant name="ForwardTOFRegion_tan" value="CentralTrackingRegionP_tan" />
<constant name="ForwardTOFRegion_minR" value="8*cm" />
<constant name="ForwardTOFRegion_minR" value="10*cm" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to detector envelope volumes require updates to the detector parameter table first, along with TIC review and approval (https://eic.jlab.org/Geometry/Detector/Detector-20240117135224.html indicates 8 cm).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I wrote, we cannot fit the actual beam pipe in the current detector. Please let me know the procedure to get it approved. Do you know who should be contacted?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current procedure is to send an email with requests for changes to the detector parameter table to the detector parameter table maintainers, the project's experiment contacts, collaboration leadership, and the specific detector contacts. I will send you their emails instead of posting them here.

<constant name="ForwardTOFRegion_maxR" value="50*cm" />
<constant name="ForwardTOF_xOffset" value="-2.75*cm" />
<constant name="ForwardTOF_det_height" value="2.0*cm" />
Expand Down Expand Up @@ -102,8 +102,8 @@
<comment> Main parameters for MPGD endcap disks, offset here is the distance between disks </comment>
<constant name="ForwardMPGD_zmin" value="148*cm"/>
<constant name="ForwardMPGDMod_offset" value="13.0*cm"/>
<constant name="ForwardMPGDMod1_rmin" value="7.014*cm" />
<constant name="ForwardMPGDMod2_rmin" value="7.014*cm"/>
<constant name="ForwardMPGDMod1_rmin" value="8.014*cm" />
<constant name="ForwardMPGDMod2_rmin" value="9.014*cm"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to detector envelope volumes require updates to the detector parameter table first, along with TIC review and approval.

<constant name="ForwardMPGDMod1_rmax" value="50*cm" />
<constant name="ForwardMPGDMod2_rmax" value="50*cm" />

Expand Down
Loading
Loading