From 8bb655ddd84bd2a5431c7092c99e207bed3e8a24 Mon Sep 17 00:00:00 2001 From: Trygve Lie <173003+trygve-lie@users.noreply.github.com> Date: Tue, 7 Jul 2020 09:13:12 +0200 Subject: [PATCH] test: Removed outcommented tests (#149) Co-authored-by: Trygve Lie --- test/sinks/test.js | 230 --------------------------------------------- 1 file changed, 230 deletions(-) diff --git a/test/sinks/test.js b/test/sinks/test.js index e5c7cf6f..f18b9271 100644 --- a/test/sinks/test.js +++ b/test/sinks/test.js @@ -45,236 +45,6 @@ const pipe = (...streams) => { }); }); } -/* -test('Sink() - Object type', (t) => { - const sink = new Sink(DEFAULT_CONFIG); - const name = Object.prototype.toString.call(sink); - t.true(name.startsWith('[object Sink'), 'should begin with Sink'); - t.end(); -}); - -test('Sink() - .write()', async (t) => { - const sink = new Sink(DEFAULT_CONFIG); - const dir = slug(); - const file = `${dir}/bar/map.json`; - - const writeFrom = readFileStream('../../fixtures/import-map.json'); - const writeTo = await sink.write(file); - - t.resolves(pipe(writeFrom, writeTo), 'should write file to sink'); - - // Clean up sink - await sink.delete(dir); - t.end(); -}); - -test('Sink() - .write() - directory traversal prevention', async (t) => { - const sink = new Sink(DEFAULT_CONFIG); - const dir = slug(); - - t.rejects(sink.write(`../../${dir}/sensitive.data`), new Error('Directory traversal'), 'should reject on ../../ at beginning of filepath'); - t.rejects(sink.write(`../${dir}/sensitive.data`), new Error('Directory traversal'), 'should reject on ../ at beginning of filepath'); - t.rejects(sink.write(`/${dir}/../../../foo/sensitive.data`), new Error('Directory traversal'), 'should reject on path traversal in the middle of filepath'); - t.resolves(sink.write(`./${dir}/sensitive.data`), 'should resolve on ./ at beginning of filepath'); - t.resolves(sink.write(`/${dir}/sensitive.data`), 'should resolve on / at beginning of filepath'); - t.resolves(sink.write(`//${dir}/sensitive.data`), 'should resolve on // at beginning of filepath'); - - // Clean up sink - await sink.delete(dir); - t.end(); -}); - -test('Sink() - .read() - File exists', async (t) => { - const sink = new Sink(DEFAULT_CONFIG); - const dir = slug(); - const file = `${dir}/bar/map.json`; - - - const writeFrom = readFileStream('../../fixtures/import-map.json'); - const writeTo = await sink.write(file); - - await pipe(writeFrom, writeTo); - - const readFrom = await sink.read(file); - - t.true(stream.isReadableStream(readFrom.stream), 'should resolve with a ReadFile object which has a .stream property'); - t.type(readFrom.etag, 'string', 'should resolve with a ReadFile object which has a .etag property'); - - const result = await pipeInto(readFrom.stream); - - t.equal(result, FIXTURE, 'should read file from sink which equals the fixture'); - - // Clean up sink - await sink.delete(dir); - t.end(); -}); - -test('Sink() - .read() - File does NOT exist', (t) => { - const sink = new Sink(DEFAULT_CONFIG); - const dir = slug(); - t.rejects(sink.read(`/${dir}/foo/not-exist.json`), 'should reject'); - t.end(); -}); - -test('Sink() - .delete() - Delete existing file', async (t) => { - const sink = new Sink(DEFAULT_CONFIG); - - const dir = slug(); - const file = `${dir}/bar/map.json`; - - const writeFrom = readFileStream('../../fixtures/import-map.json'); - const writeTo = await sink.write(file); - - await pipe(writeFrom, writeTo); - - t.resolves(sink.exist(file), 'should resolve - file is in sink before deletion'); - - await sink.delete(file); - - t.rejects(sink.exist(file), 'should reject - file was deleted'); - - // Clean up sink - await sink.delete(dir); - t.end(); -}); - -test('Sink() - .read() - directory traversal prevention', async (t) => { - const sink = new Sink(DEFAULT_CONFIG); - const dir = slug(); - const file = `${dir}/map.json`; - - const writeFrom = readFileStream('../../fixtures/import-map.json'); - const writeTo = await sink.write(file); - - await pipe(writeFrom, writeTo); - - t.rejects(sink.read(`../../${dir}/sensitive.data`), new Error('Directory traversal'), 'should reject on ../../ at beginning of filepath'); - t.rejects(sink.read(`../${dir}/sensitive.data`), new Error('Directory traversal'), 'should reject on ../ at beginning of filepath'); - t.rejects(sink.read(`/${dir}/../../../foo/sensitive.data`), new Error('Directory traversal'), 'should reject on path traversal in the middle of filepath'); - t.resolves(sink.read(`./${file}`), 'should resolve on ./ at beginning of filepath'); - t.resolves(sink.read(`/${file}`), 'should resolve on / at beginning of filepath'); - t.resolves(sink.read(`//${file}`), 'should resolve on // at beginning of filepath'); - - // Clean up sink - await sink.delete(dir); - t.end(); -}); - -test('Sink() - .delete() - Delete non existing file', (t) => { - const sink = new Sink(DEFAULT_CONFIG); - t.resolves(sink.delete('/bar/foo/not-exist.json'), 'should resolve'); - t.end(); -}); - -test('Sink() - .delete() - Delete file in tree structure', async (t) => { - const sink = new Sink(DEFAULT_CONFIG); - const dir = slug(); - const fileA = `${dir}/a/map.json`; - const fileB = `${dir}/b/map.json`; - - const writeFromA = readFileStream('../../fixtures/import-map.json'); - const writeToA = await sink.write(fileA); - await pipe(writeFromA, writeToA); - - const writeFromB = readFileStream('../../fixtures/import-map.json'); - const writeToB = await sink.write(fileB); - await pipe(writeFromB, writeToB); - - await sink.delete(fileA); - - t.rejects(sink.exist(fileA), 'should reject on file A - file was deleted'); - t.resolves(sink.exist(fileB), 'should resolve on file B - file was NOT deleted'); - - // Clean up sink - await sink.delete(dir); - t.end(); -}); - -test('Sink() - .delete() - Delete files recursively', async (t) => { - const sink = new Sink(DEFAULT_CONFIG); - const dir = slug(); - const fileA = `${dir}/a/map.json`; - const fileB = `${dir}/b/map.json`; - - const writeFromA = readFileStream('../../fixtures/import-map.json'); - const writeToA = await sink.write(fileA); - await pipe(writeFromA, writeToA); - - const writeFromB = readFileStream('../../fixtures/import-map.json'); - const writeToB = await sink.write(fileB); - await pipe(writeFromB, writeToB); - - await sink.delete(dir); - - t.rejects(sink.exist(fileA), 'should reject on file A - file was deleted'); - t.rejects(sink.exist(fileB), 'should reject on file B - file was deleted'); - - t.end(); -}); - -test('Sink() - .delete() - directory traversal prevention', async (t) => { - const sink = new Sink(DEFAULT_CONFIG); - const dir = slug(); - const file = `${dir}/map.json`; - - t.rejects(sink.delete(`../../${dir}/sensitive.data`), new Error('Directory traversal'), 'should reject on ../../ at beginning of filepath'); - t.rejects(sink.delete(`../${dir}/sensitive.data`), new Error('Directory traversal'), 'should reject on ../ at beginning of filepath'); - t.rejects(sink.delete(`/${dir}/../../../foo/sensitive.data`), new Error('Directory traversal'), 'should reject on path traversal in the middle of filepath'); - t.resolves(sink.delete(`./${file}`), 'should resolve on ./ at beginning of filepath'); - t.resolves(sink.delete(`/${file}`), 'should resolve on / at beginning of filepath'); - t.resolves(sink.delete(`//${file}`), 'should resolve on // at beginning of filepath'); - - // Clean up sink - await sink.delete(dir); - t.end(); -}); - -test('Sink() - .exist() - Check existing file', async (t) => { - const sink = new Sink(DEFAULT_CONFIG); - const dir = slug(); - const file = `${dir}/map.json`; - - const writeFrom = readFileStream('../../fixtures/import-map.json'); - const writeTo = await sink.write(file); - - await pipe(writeFrom, writeTo); - - t.resolves(sink.exist(file), 'should resolve - file is in sink'); - - // Clean up sink - await sink.delete(dir); - t.end(); -}); - -test('Sink() - .exist() - Check non existing file', (t) => { - const sink = new Sink(DEFAULT_CONFIG); - t.rejects(sink.exist('/bar/foo/not-exist.json'), 'should reject - file does not exist'); - t.end(); -}); - -test('Sink() - .exist() - directory traversal prevention', async (t) => { - const sink = new Sink(DEFAULT_CONFIG); - const dir = slug(); - const file = `${dir}/map.json`; - - const writeFrom = readFileStream('../../fixtures/import-map.json'); - const writeTo = await sink.write(file); - - await pipe(writeFrom, writeTo); - - t.rejects(sink.exist(`../../${dir}/sensitive.data`), new Error('Directory traversal'), 'should reject on ../../ at beginning of filepath'); - t.rejects(sink.exist(`../${dir}/sensitive.data`), new Error('Directory traversal'), 'should reject on ../ at beginning of filepath'); - t.rejects(sink.exist(`/${dir}/../../../foo/sensitive.data`), new Error('Directory traversal'), 'should reject on path traversal in the middle of filepath'); - t.resolves(sink.exist(`./${file}`), 'should resolve on ./ at beginning of filepath'); - t.resolves(sink.exist(`/${file}`), 'should resolve on / at beginning of filepath'); - t.resolves(sink.exist(`//${file}`), 'should resolve on // at beginning of filepath'); - - // Clean up sink - await sink.delete(dir); - t.end(); -}); -*/ - test('Sink() - Object type', (t) => { const sink = new Sink(DEFAULT_CONFIG);