Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace convict with configuration as parameters #578

Open
wkillerud opened this issue Jul 31, 2024 · 0 comments
Open

Replace convict with configuration as parameters #578

wkillerud opened this issue Jul 31, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@wkillerud
Copy link
Contributor

wkillerud commented Jul 31, 2024

Related #484

We should not have a dependency on convict inside the service. When running with npx it should take its parameters as arguments or as environment variables.

We're seeing some weirdness in the API after #577. We're making a logger instance and would like to access the name and loglevel configured locally in our Eik server, but there's a catch 22 where we can't get to service.config to read them. We then duplicate some convict stuff locally and it just gets a bit messy.

This would be a breaking change.

@wkillerud wkillerud added the enhancement New feature or request label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant