Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting an error when running the main Civi cron job #123

Open
Upperholme opened this issue Mar 6, 2023 · 3 comments
Open

Getting an error when running the main Civi cron job #123

Upperholme opened this issue Mar 6, 2023 · 3 comments

Comments

@Upperholme
Copy link

Over the weekend I updated to the latest master version of this extension, which looks to have fixed issues with my sync to Xero. However my main cron job has stopped working since.

I'm seeing the following error reported:

TypeError: Argument 2 passed to CRM_Civixero_Invoice::mapCancelled() must be of the type int, null given, called in /home/inca/sites/default/sites/all/extensions/nz.co.fuzion.civixero-master/CRM/Civixero/Invoice.php on line 426 in CRM_Civixero_Invoice->mapCancelled() (line 273 of /home/inca/sites/default/sites/all/extensions/nz.co.fuzion.civixero-master/CRM/Civixero/Invoice.php).

Any pointers on this issue gratefully received.
eileenmcnaughton added a commit that referenced this issue Mar 6, 2023
@eileenmcnaughton
#123 Fix type hint on mapCancelled
f35de92
@eileenmcnaughton
Copy link
Owner

I pushed a fix

@Upperholme
Copy link
Author

Great, thanks. I'll give it a spin.

@eileenmcnaughton
Copy link
Owner

I think we can close this now? 2.1.4 working afaik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eileenmcnaughton @Upperholme