Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot demand that -export-fixes is on the command line #1

Open
espenfk opened this issue Nov 22, 2019 · 4 comments
Open

Cannot demand that -export-fixes is on the command line #1

espenfk opened this issue Nov 22, 2019 · 4 comments

Comments

@espenfk
Copy link

espenfk commented Nov 22, 2019

if len(invocation.ExportFile) == 0 || len(invocation.DatabaseRoot) == 0 || len(invocation.TargetPath) == 0 {

@espenfk
Copy link
Author

espenfk commented Nov 22, 2019

Isn't it possible to use other means to cache , I mean. At least put in the documentation that it is -export-fixes that is the crux here.

@espenfk
Copy link
Author

espenfk commented Nov 22, 2019

I think this project is a good idea, but it doesn't work "out-of-the-box", at least not for me. I have checked out the source code and the code I don't understand is line 17 in cache.go. It tries to read a file .clang-tidy that should be in the working directory, but it is not, at least not for me. I don't understand which file you try to hash there, because the natural thing to hash is the command from the compile_commands.json file.

@funous
Copy link
Contributor

funous commented Apr 22, 2021

Some of this issues (generally better out of the box experience) are addressed in #3. It removes the need to use -export-fixes and also improves the search for .clang-tidy and compile_commands.json.

@ejfitzgerald
Copy link
Owner

@espenfk I have included @funous contribution in the latest release:

https://github.com/ejfitzgerald/clang-tidy-cache/releases/tag/v0.3.0

Please let me know if this solves you issue

mathstuf pushed a commit to mathstuf/clang-tidy-cache that referenced this issue Jan 18, 2023
ci: add release ci to upload binaries for all os and architectures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants