Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out whether we can avoid passing a conn_id in Service messages and otherwise document why #3

Open
najamelan opened this issue Mar 11, 2019 · 0 comments
Open

Figure out whether we can avoid passing a conn_id in Service messages and otherwise document why #3

najamelan opened this issue Mar 11, 2019 · 0 comments
Assignees
@najamelan
Labels
Contribute ⦔ Only Assigned Difficulty ⦔ Software Design Domain ⦔ Usability Est. Work ⦔ 1h OS ⦔ All Priority ⦔ High State ⦔ Open Type ⦔ Improvement

Comments

@najamelan
Copy link
Member

Currently a service always returns IpcMessage, which means that the Service message needs to have the conn_id in it in order to correctly make the ipcmessge. Ideally the response type would be the response type of the service and rpc takes care of creating the ipc message.

This would give a cleaner and leaner api...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@najamelan najamelan

Labels
Contribute ⦔ Only Assigned Difficulty ⦔ Software Design Domain ⦔ Usability Est. Work ⦔ 1h OS ⦔ All Priority ⦔ High State ⦔ Open Type ⦔ Improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@najamelan