Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove spaces from lists of files to upload to PBW #25

Open
ekolis opened this issue Apr 15, 2020 · 2 comments
Open

Remove spaces from lists of files to upload to PBW #25

ekolis opened this issue Apr 15, 2020 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers tweak A simple change.
Milestone
v1.2.1

Comments

@ekolis
Copy link
Owner

ekolis commented Apr 15, 2020

I think those are causing all but the first entry to be skipped as AutoPBW looks for literal spaces in filenames. This might be behind the missing combat replays issue...
@ekolis ekolis added bug Something isn't working good first issue Good for newcomers tweak A simple change. labels Apr 15, 2020
@ekolis ekolis added this to the v1.1.1 milestone Apr 15, 2020
@ekolis
Copy link
Owner Author

ekolis commented Apr 15, 2020

Just to be clear, this change should be made in the default config file.

@ekolis
Copy link
Owner Author

ekolis commented Apr 15, 2020 •
edited
Loading

Alternately, we can string.Trim() the spaces off of the file lists; that way users wouldn't have to do it manually if they already have a config file!

@ekolis ekolis modified the milestones: v1.1.1, v1.2.0 Jan 17, 2021
@ekolis ekolis modified the milestones: v1.2.0, v1.3.0, v1.2.1 Jan 29, 2021
@ekolis ekolis moved this to To do in AutoPBW Configuration Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers tweak A simple change.
Projects
AutoPBW Configuration
Status: To do
Milestone
v1.2.1
Development

No branches or pull requests
1 participant
@ekolis