Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guidance on cloud control api resources #502

Closed
corybekk opened this issue Jan 9, 2025 · 8 comments · Fixed by #505
Closed

Guidance on cloud control api resources #502

corybekk opened this issue Jan 9, 2025 · 8 comments · Fixed by #505

Comments

@corybekk
Copy link

corybekk commented Jan 9, 2025

Hi there,
I see that config-cloud-control.md says "coming soon" and was wondering if the old cloud-control config.yml functionality is still supported?

Context:

In the previous version of aws-nuke, we used the cloud-control attribute in config.yml to handle resources without a corresponding package under aws-nuke/resources. However, after migrating our configuration file to use this version of aws-nuke, I noticed that Cloud Control API resources are not being picked up.

Here’s a small simplified example:

resource-types:
  includes:
    - AccessAnalyzer
    - ACMCertificate
    - APIGatewayAPIKey
  alternatives:
    - AWS::Bedrock::Agent
    - AWS::Bedrock::Flow

Could you confirm if this functionality is still supported?
Thanks!

@ekristen
Copy link
Owner

ekristen commented Jan 9, 2025

They are still supported even though the docs are missing but only if the resource supports it, in this case the bedrock resource don't have alternatives defined at the moment.

@ekristen
Copy link
Owner

ekristen commented Jan 9, 2025

If you go to https://aws-nuke.ekristen.dev and search for "Alternative Resource" you'll see which resources currently support Alternative Resources. Alternatively you can use the CLI directly to do this aws-nuke list-resources - any alternatives will be in yellow by default and intended under the primary resource type.

@corybekk
Copy link
Author

corybekk commented Jan 9, 2025

They are still supported even though the docs are missing but only if the resource supports it, in this case the bedrock resource don't have alternatives defined at the moment.

@ekristen Thank you, I really appreciate the help. Just to confirm, cloud control api resources can no longer be used unless a corresponding package has been created with AlternativeResource defined?

@ekristen
Copy link
Owner

ekristen commented Jan 9, 2025

@corybekk you had me curious, I was about to say that it's always been that way, but it looks like I would have been wrong. A nuance I might have missed is that previously you could pass in any AWS::<resource> and it would attempt to control via Cloud Control API, I do believe that functionality was never ported over, that is and was an oversight.

I will have to look more closely at this to determine what got removed and how to bring back that functionality.

@ekristen
Copy link
Owner

ekristen commented Jan 9, 2025

#503

@corybekk
Copy link
Author

corybekk commented Jan 9, 2025

Thank you @ekristen!

@corybekk corybekk closed this as completed Jan 9, 2025
@ekristen
Copy link
Owner

ekristen commented Jan 9, 2025

Thanks for bringing this to my attention, this is a bit more complicated of a fix, I'll try and look into it tonight.

@ekristen
Copy link
Owner

🎉 This issue has been resolved in version 3.43.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants