Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please support 1.21.4 #1402

Open
Happmc2525 opened this issue Jan 17, 2025 · 5 comments
Open

Please support 1.21.4 #1402

Happmc2525 opened this issue Jan 17, 2025 · 5 comments

Comments

@Happmc2525
Copy link

Does not work with 1.21.4

@ody
Copy link

ody commented Jan 18, 2025

I would also appreciate this.

@NathanWolf
Copy link
Member

Dev builds with 1.21.4 support are here: https://jenkins.elmakers.com/job/MagicPlugin/4316/

I haven't released this (or even 1.21.3 support) yet officially because vehicle controls are broken. I'd really like to find a fix for that, but not sure it's going to happen so I may release this as-is.

@ody
Copy link

ody commented Jan 31, 2025

@NathanWolf Thank you for the build. Been testing for the last couple days and overall the plugin seems "functional" on 1.21.4. I've ran into two issues so far, the first was rather confusing and I burned a few hours scratching my head and clicking in circles.

  1. You are unable to open a spell book to drag spells onto your hot bar if you only know one spell

This makes crafting a spell book a very frustrating experience as it is impossible to cast Magic Missile from the new book until you've learned a second spell. That is impossible since you can't earn spell points without casting spells. If you start with a wand, gain some SP and then learn a second spell, you'll be able to use a spell book.

  1. Only about half the resource pack seems to work

Spell icons display above the resource pack provided mana bar but there are no wand textures/models.

@NathanWolf
Copy link
Member

For #2 .. it kind of looks like I have to completely re-write the RP for 1.21.4

Not sure when that's likely to happen :(

@NathanWolf
Copy link
Member

Ok I got the RP mostly working. It's a new RP version, the latest dev build will use it or you can manually switch.

http://rp.elmakers.com/Magic-RP-1.21.4.zip

I'm not sure that everything is working but wands and spells should appear again.

I also fixed the issue with the spell book when it only has one spell. This had nothing to do with 1.21 and sadly was probably like that since forever .. not sure how I never realized that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants