Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate problems with our router #758

Open
LukasKalbertodt opened this issue Mar 16, 2023 · 0 comments
Open

Investigate problems with our router #758

LukasKalbertodt opened this issue Mar 16, 2023 · 0 comments
Labels
area:frontend Everything frontend related kind:improvement

Comments

@LukasKalbertodt
Copy link
Member

When checking something else, I noticed that the router might do some unintended stuff. This needs to be investigated and if true, fixed.

  • When clicking on a link once, the transition animation starts and the old page stays visible. Good. But when clicking another link during that transition/loading, the whole page (<main> part) is replaced with "loading" (e.g. <InitialLoading />). Bad.
  • I think routes that didn't finish loading before the user initiated navigation to another router are not disposed.
@LukasKalbertodt LukasKalbertodt added area:frontend Everything frontend related kind:improvement labels Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:frontend Everything frontend related kind:improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LukasKalbertodt