Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pre-authenticated buttons in Safari (iOS) #831

Open
LukasKalbertodt opened this issue May 15, 2023 · 3 comments
Open

Fix pre-authenticated buttons in Safari (iOS) #831

LukasKalbertodt opened this issue May 15, 2023 · 3 comments
Labels
area:frontend Everything frontend related kind:bug Bug

Comments

@LukasKalbertodt
Copy link
Member

The buttons for Studio and editor don't work if pre-authentication is enabled. In that case, it's actually a <form> with some hidden inputs. And the button is supposed to submit that form. That doesn't happen on Safari though (at least on iOS). Maybe because we have a custom click handler attached to the button, the default "submit" behavior isn't triggered anymore?

@LukasKalbertodt LukasKalbertodt added area:frontend Everything frontend related kind:bug Bug labels May 15, 2023
@LukasKalbertodt LukasKalbertodt added this to the v2.7 milestone Feb 20, 2024
@LukasKalbertodt LukasKalbertodt removed this from the v2.7 milestone Mar 12, 2024
@owi92
Copy link
Member

owi92 commented Apr 17, 2024

The "submit" behaviour appears to be triggered, but I think the issue might be caused by the built-in popup blocker in safari. I cannot say for sure as browserstack unfortunately doesn't allow turning that off in our price tier..... @LukasKalbertodt, if you haven't done this yet, can you test turning it off on your iphone?

@LukasKalbertodt
Copy link
Member Author

I did turn off "Content blockers" and my "AdGuard" extension, but still: doesn't work.

@owi92
Copy link
Member

owi92 commented Apr 23, 2024

Yeah I was afraid that it wouldn't help either. This is a pain to debug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend Everything frontend related kind:bug Bug
Projects
None yet
Development

No branches or pull requests

2 participants