Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Added node.roles in readme and created deprecation warning #772

Closed
wants to merge 1 commit into from

Conversation

Bernhard-Fluehmann
Copy link
Contributor

Proposal to fix #731

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@jmlrt
Copy link
Member

jmlrt commented Feb 24, 2021

Thanks for this PR.
This will need a bit more investigation in our side to ensure this is the way we want it to be implemented.

Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bernhard-Fluehmann, thanks for this PR and sorry for the delay.
I wanted to investigate if it would worth to do it another way to be consistent with how we'll handle this change in Elasticsearch Helm chart, however I think this PR is fine for Ansible Elasticsearch.

Can you also update:

node.data: false
node.master: true

The rest LGTM:+1:

@botelastic
Copy link

botelastic bot commented Jul 11, 2021

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
To track this PR (even if closed), please open a corresponding issue if one does not already exist.

@botelastic
Copy link

botelastic bot commented Aug 10, 2021

This PR has been automatically closed because it has not had recent activity since being marked as stale.
Please reopen when work resumes.

@botelastic botelastic bot closed this Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use node.roles instead of deprecated setting for Elasticsearch 7.9+
3 participants